[pkg] brutespray - review

Stéphane Neveu stefneveu at gmail.com
Wed Jul 26 11:18:43 UTC 2017


Hi all,

Thank you again Lukas, so now brutespray should be ready :)

Best regards,

Stephane

2017-07-25 16:00 GMT+02:00 Lukas Schwaighofer <lukas at schwaighofer.name>:
> Hi,
>
> On Tue, 25 Jul 2017 15:36:21 +0200
> Stéphane Neveu <stefneveu at gmail.com> wrote:
>> * -o option has also been added to provide a custom output directory
>> (install.patch is pointing on /usr/share/brutespray for that dir)
>
> That's not a good default, because normal users won't have write
> permissions there…  keeping brutespray-output (relative to the cwd)
> seems like a reasonable default to me.
>
>
> Otherwise I think you've addressed everything I had raised.  Great that
> you were able to introduce proper temporary file handling upstream!
>
> Regards
> Lukas



More information about the Pkg-security-team mailing list