DD request: review chkrootkit

[Gianfranco Costamagna]

hello,

pushed in deferred/5, let me know if I have to cancel or reschedule it

G.



Il Martedì 25 Luglio 2017 11:33, Marcos Fouces <marcos.fouces at gmail.com> ha scritto:



Good! Injecting CFLAGS solves to problem!

Thanks for help.

Greetings.

Marcos




El 25/07/17 a las 01:27, Lukas Schwaighofer escribió:
> On Tue, 25 Jul 2017 00:02:06 +0200
> Marcos Fouces <marcos.fouces at gmail.com> wrote:
>
>> Hello Lukas
>>
>> I followed all your suggestions but one:
>>
>> * If i drop -g flag, the resulting dbgsym package does not contain
>> debug symbols (and Lintian complaints about it...). I am confused
>> about the fact that it is not a preprocessor flag but seems to do its
>> work.
> Great! The proper fix for that one is to add ${CFLAGS} also to this
> target:
>
> strings-static:   strings.c
>     ${CC} ${STATIC} ${CPPFLAGS} ${LDFLAGS} -o $@ strings.c
>
> (this is important anyways, otherwise some other hardening options are
> missing as well)
>
> ~lukas