Bug#853570: marked as pending
Gianfranco Costamagna
locutusofborg at debian.org
Fri Aug 25 14:22:27 UTC 2017
Hello Raphael,
> + * Add patch to fix build with gcc 7. Closes: #853570
I see fedora is carrying the following patch:
diff -ru ncrack-0.5/ncrack_resume.cc ncrack-0.5.new/ncrack_resume.cc
--- ncrack-0.5/ncrack_resume.cc 2016-04-10 18:56:02.000000000 +0200
+++ ncrack-0.5.new/ncrack_resume.cc 2017-04-13 17:53:09.369522756 +0200
@@ -520,7 +520,7 @@
j = 0;
buf[j++] = *q;
- while (q != '\0' && j < sizeof(buf)) {
+ while ((q != NULL) && (j < sizeof(buf))) {
q++;
if (q - filestr >= filelen)
fatal("Corrupted file! Error 5\n");
isn't it better (I think your approach might lead to segfaults in case the pointer
is NULL).
(I'm uploading the following patch right now)
G.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170825/3b5f8f53/attachment.sig>
More information about the Pkg-security-team
mailing list