new hydra version (Was: Re: open DD requests)

[Lukas Schwaighofer]

Hi Ganifranco,

thanks for sponsoring and sorry for the late reply (I was on vacation
and there was no need for immediate action).

On Thu, 10 Aug 2017 15:47:42 +0000 (UTC)
Gianfranco Costamagna <locutusofborg at debian.org> wrote:

> >   override_dh_clean:
> >           dh_clean --exclude=Makefile.orig  
> 
> 
> I don't usually care about it, as long as upstream is aware and
> removes on a future release.
> 
> So, please drop that hack (I prefer a warning rather than a possible
> future useless hack), and send a message to upstream including to
> remove it in the future :)

Well, it's not that easy; they include the Makefile.orig on purpose
(it's not debris) and their Makefile contains:

    clean:
            cp -f Makefile.orig Makefile

So when Makefile.orig does not exist, `make clean` and therefore also
`./debian/rules clean` fails.  While upstream's build system is not
standard, there's nothing wrong with it.  I'm not really comfortable
asking them to change it.

Do you still think that excluding Makefile.orig from dh_clean is a hack
in this case?  The source package should contain the Makefile.orig file
since it's part of upstream's build system.  If I drop the override,
then executing `./debian/rules clean` twice in a row fails.

Thanks
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170827/0b5a488a/attachment.sig>