Bug#876093: openvas-libraries FTBFS on amd64: override_dh_auto_configure failed

[Raphael Hertzog]

Control: tag -1 + patch

Hello,

On Mon, 18 Sep 2017, SZ Lin wrote:
> CMake Error at nasl/CMakeLists.txt:147 (add_library):
> Target "openvas_nasl_shared" links to item " -lpcap" which has leading or
> trailing whitespace. This is now an error according to policy CMP0004.
> 
> This issue is caused by libpcap-dev [1], and the following patch could
> solve this issue.
> [1] https://anonscm.debian.org/cgit/users/rfrancoise/libpcap.git/commit/?id=95f3623920effd288b7add3e8d2f0092c5bb46a6
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 033d122..71deefc 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -212,6 +212,7 @@ if (NOT OPENVAS_OMP_ONLY)
>      execute_process (COMMAND pcap-config --cflags
>        OUTPUT_VARIABLE PCAP_CFLAGS
>        OUTPUT_STRIP_TRAILING_WHITESPACE)
> +    string(STRIP "${PCAP_LDFLAGS}" PCAP_LDFLAGS)
>    else (PCAP_CONFIG)
>      message (STATUS "pcap-config not found, using defaults...")
>      set (PCAP_LDFLAGS "-L/usr/lib -lpcap")
> 
> Any feedback on it?

No, looks good. Feel free to push the fix to git and to submit it
upstream.

Thank you.
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/