ITP:inetsim -- Software suite for simulating common internet services

Lukas Schwaighofer lukas at schwaighofer.name
Fri Sep 22 16:06:35 UTC 2017


Hi GengYu,

On Fri, 22 Sep 2017 14:35:56 +0000
yoo z <zouyoo at outlook.com> wrote:

> Thanks for your support , i'm quite new to Debian pkg ,If I made any
> stupid mistake

Don't worry about it, we all make mistakes that may appear to be
stupid in the beginning :) .

> And I managed to create it from the kali's repo, which belongs to
> Devon Kearns years ago.  I updated it with the latest inetsim.
> 
> This is my repo and you can modify it if i made any mistake.
> https://github.com/Z-Y00/inetsim-Debian/

I just took a quick look.  The changes you made look ok so far, but
you are not yet using git-buildpackage (gbp) correctly.  Let's work on
that first before I take a closer look at the package itself :) .

When packaging with gbp, the repositories follow a specific layout. The
details are explained here:
http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.intro.html#GBP.REPOSITORY

When you want to import a new upstream version, you need to use the
`gbp import-orig` command, see man gbp-import-orig(1), to add that to
your repository. Since your package has a watch file, you can even use
`gbp import-orig --uscan` to download the most recent upstream tarball
and add it to your repository with just a single command.

Importing the new version using gbp ensures that:
* the upstream changes are applied to the "upstream" branch and tagged
  with their version number
* the result of the updated upstream branch is then merged into your
  development branch
* the pristine-tar branch is kept up to date (provided you have
  configured gbp as explained on our team's wiki page)

Also I'd suggest you re-read the team's wiki page, since we try to
follow DEP14 for our gbp repository layout:
https://dep.alioth.debian.org/deps/dep14/

Please try to correct your repository.  It may be easier to start over
and re-apply your changes.  After you've done that, please push all
three branches (which should be called "debian/master",
"upstream/latest" and "pristine-tar") as well as any tags you have
created.

If you need help with the above don't hesitate to ask.

Let me know once you have corrected the repository layout.  I'll make a
review of your package then.

> I tried to create one repo on git.debian.org , but I'm not in this
> team

I think you can apply to join the team on the alioth project page:
https://alioth.debian.org/projects/pkg-security

One of the alioth project admins will then be able to add you to the
team.  For now it's also perfectly fine to work using your github
repository.

> If you think it is suitable , i'm glade this to be a team maintained 
> package.  Also, I hope if you can help me upload this, I'm not Debian
> Maintainer nor Develpoer and need RFS.

I think the package fits well enough in the team's quite broad
"security" scope.

I'm not a Debian Developer either, so I won't be able to sponsor your
package.  But I already have a bit of experience, so I can help you
with packaging if you want.  Once we're both satisfied, we can ask one
of the team's Debian Developers to also review and sponsor it if they
are satisfied.

Regards
Lukas



More information about the Pkg-security-team mailing list