inetsim

[Lukas Schwaighofer]

Hi GenYu,

On Tue, 17 Oct 2017 16:04:41 +0000
yoo z <zouyoo at outlook.com> wrote:

>   Hoping everything is right this time

Looks mostly good, we're getting closer :) .  But you also introduced
a few new problems:

* Your debian/watch file no longer works (`uscan -dd` reports errors).
  The problem is you have "opts" twice; instead you should only use
  it once and separate the options with commas (or comma and space if
  you use version=4).  You may also need to quote them.
  - You also need to add a rule so the correct dfsg suffix is added to
    the repacked version.  Use the repacksuffix= option as explained in
    uscan(1) in addition to the options you are already using.

* I currently cannot build the package using git-buildpackage at all,
  because the orig tarball in the pristine-tar branch has a wrong
  name, more precisely the version encoded in the filename is wrong:
  - It's inconsistent with the version in debian/control:
    "dfsg1" vs "dfsg.1"
  - It includes the Debian revision, which it shouldn't (the upstream
    tarball must never change when only the Debian revision changes)

* The "dfsg.1" tag is meaningless (pushing this was probably a
  mistake). Please remove it if you can.

* I wouldn't install README.Debian to /usr/share/inetsim/contrib, it's
  sufficient to be in /usr/share/doc/inetsim (where it's installed
  automatically).

Still haven't tried inetsim, will hopefully be able to do so tomorrow.

Regards
Lukas