inetsim

[Lukas Schwaighofer]

Hi GengYu,

please don't make force commits.  It's hard for me to keep track of new
changes that way and review them properly…

* The version in git again does not build using `git buildpackage`,
  because debian/inetsim.install is an executable file.
* debian/control:
  - Maintainer should be: Debian Security Tools Packaging Team
    <pkg-security-team at lists.alioth.debian.org>
  - Add yourself to Uploaders instead
  - dh-exec is no longer required as build dependency, remove it

On Wed, 18 Oct 2017 08:57:30 +0000
yoo z <zouyoo at outlook.com> wrote:

> I edited the watch file and now it works finally.
> uscan info: New orig.tar.* tarball version (oversionmangled):
> 1.2.6+dfsg.1 uscan info: Executing internal command:
>     mk-origtargz --package inetsim --version 1.2.6+dfsg.1
> --compression gzip --directory .. --copyright-file debian/copyright 
> ../inetsim-1.2.6.tar.gz
> uscan info: New orig.tar.* tarball version (after mk-origtargz): 
> 1.2.6+dfsg.1
> uscan info: Successfully repacked ../inetsim-1.2.6.tar.gz as 
> ../inetsim_1.2.6+dfsg.1.orig.tar.gz, deleting 2 files from it.
> uscan info: Scan finished

While it does work, it's not semantically correct: uversionmangle
should only be used to make minor adjustments to upstream versions to
conform to Debian's sorting (e.g. introduce ~ into release candidate
versions).  To illustrate what I mean, with your watch file uscan
outputs:

uscan info: Newest version of inetsim on remote site is 1.2.6+dfsg.1,
            local version is 1.2.6+dfsg.1

Correctly uscan would report:

uscan info: Newest version of inetsim on remote site is 1.2.6, local
            version is 1.2.6+dfsg.1

That can be achieved by using both the dversionmangle and repacksuffix
options.  You've also dropped the pgpsigurlmangle option which I
think is still useful. I've attached a patch which applies all the
options in a way that I think is correct.

> > * I wouldn't install README.Debian to /usr/share/inetsim/contrib,
> > it's sufficient to be in /usr/share/doc/inetsim (where it's
> > installed automatically).  
> I guess it would be fine to put the README to where those files have 
> been removed from.

By convention, things that are specific to the Debian package and do
not apply to upstream are documented
in /usr/share/doc/pkgname/README.Debian .  Replacing the (not
necessary) binaries with dummies would be one such deviation, so that
is the right place.


Now, I've installed inetsim.  However, the service does not start with
the following logged to my journal:

    Oct 18 21:30:26 redacted inetsim[2959]: Not starting INetSim.
    Edit /etc/default/inetsim to enable ... (warning).

However, /etc/default/inetsim does not exist at all, so I cannot edit
it.  Please test inetsim by actually starting the daemon!  Create
the /etc/default/inetsim file as needed and put it into the package.
Once you're satisfied starting inetsim works let me know and I will take
another look.

Regards
Lukas

PS: Having something like "ENABLED=0" in /etc/default/SERVICENAME is in
the process of being deprecated in the debian policy [1]… however there
isn't a nice way to install a package with a disabled service yet.  But
I guess there will be soon, as a version of init-system-helpers with
support for that was uploaded last week [2].

[1] https://bugs.debian.org/601455
[2] https://bugs.debian.org/857452
-------------- next part --------------
A non-text attachment was scrubbed...
Name: watch.patch
Type: text/x-patch
Size: 397 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20171018/b30b4a1a/attachment.bin>