intetsim review (Re: ITP: inetsim)

[Lukas Schwaighofer]

Hi GenYu,

On Fri, 20 Oct 2017 02:37:06 +0000
yoo z <zouyoo at outlook.com> wrote:
> It is sad to know that we have been packing the tool in a complete
> wrong way. we put the files in a wrong place, and use a dirty
> helper-script to launch it. (...)

While there are certainly more and less clean ways to package
something, we have not done anything "wrong".  I'm aware that in
your work in progress package, some of the files are not yet installed
to a suitable location.  That was still on my TODO list ;) .

Helper scripts, like the one shipped in your inetsim package, are
somewhat a compromise.  The alternative to the helper script is
patching the "inetsim" perl script slightly and install it
to /usr/bin (that appears to be what upstream does).  Using a helper
script is a bit ugly but less likely to break when upstream changes
something.  I believe both are valid choices for packaging.

> would you help to maintain the package, since you will use quilt and
> you can directly commit to your source package, this would solve many
> problems, and we can do it before release 1.2.7. It would be great if
> we can have a look at 1.2.7's debian/* before you release this
> version.

Just for your information (I don't know if you know this already):
Debian source packages in "3.0 (quilt)" format always contains at least
two tarballs (exactly two in most cases).  One of them contains the
packaging files for Debian created by the Debian maintainer(s), the
others contain source code taken from upstream.  If upstream's tarball
includes a debian directory, it is automatically removed when the
source package is unpacked.  That means that if you want to use the
debian directory from upstream, you need to copy it.

Therefore it's not important to have access to the debian directory
upstream uses and/or ships with the upcoming release beforehand.  In
most cases you will have to make at least some small changes to those
packaging files anyways…

Regards
Lukas