intetsim review (Re: ITP: inetsim)

[Lukas Schwaighofer]

Hi GengYu,

On Tue, 14 Nov 2017 15:43:39 +0000
GengYu Rao <zouyoo at outlook.com> wrote:
>   For this tool,actually,people would always launch it from console
> instead of run it as a service.
>   For instance, if you wanna to test the malware sample against
> logical fault with time setting (you may need this if it is scheduled
> to run at certain time, or unlock the files after one year)
> you can use
>     --faketime-init-delta <initial time delta>
>     --faketime-auto-delay <delay time>
> And it is a lot of options you want to use.

Well, probably not *always* (otherwise upstream wouldn't supply the
init file either), but I can see that it makes more sense to launch it
from the console in most cases.  So shipping it with an init script
disabled by default seems like a reasonable choice.

> > * A lot of files are now installed to both
> >    /usr/share/inetsim/lib/ and /usr/share/perl5, they should only be
> >    installed once.
> >
> > * You changed the location for a lot of files, but the "old" (empty)
> >    directories are still part of the package.
> >    - The "report" symlink still points
> > to /var/lib/inetsim/report .  
> 
> > - Install inetsim directly to /usr/bin, drop the helper script
> >  - To make sure the correct conf, data and log directories are used
> > by inetsim when started from the init script, add
> >       --chdir /usr/share/inetsim  
> 
> Some files are duplicated to launch it in both way.

They don't need to be duplicated for that.  The chdir
to /usr/share/inetsim only changes the current working directory (cwd).
It is needed, because inetsim uses the ./conf, ./data, ./log
and ./report directories relative to the cwd by default.  The lib
subdir is not needed, the inetsim perl script should be able find its
modules in /usr/share/perl5 just fine.

> The easier way is to add the helper script and cd there,
> like the init script. This would avoid many problems.

Which problems specifically?

> The other way is to patch the files, the upstream adopt this way
> and they cp some files in postinst from /usr/share to /var/lib.

I don't understand what you mean with that.

Regards
Lukas