ITP: inetsim

[Lukas Schwaighofer]

Hi,

unfortunately I don't have time tonight to look at the changes you
made in git, so I'm just responding to your mail.

On Thu, 1 Feb 2018 05:18:02 +0000
GengYu Rao <zouyoo at outlook.com> wrote:

> and there is a little problem with the postinit
> 
> the scripts created by the #DEBHELPER# have this line
> 
> if [ -x "/etc/init.d/inetsim" ]; then
>          update-rc.d inetsim defaults >/dev/null
> 
> I copied the scripts created by the #DEBHELPER#,
> changed it to disable and dropped the #DEBHELPER#

You shouldn't do that.  This will create problems that are hard to
detect eventually.  For example once you use other functions from
debhelper.  You will also miss out on any improvements made in
debhelper that affect the script generation.

Instead, please read the manpage of dh_installinit(1).  The options
--no-start and --no-enable look like they might do the right thing, so
you will end up with something like this in debian/rules:

override_dh_installinit:
        dh_installinit --your --options --here

The option description of --no-start seems to imply that you need to
take care of stopping the service yourself on removal, please check
that and modify the maintainer scripts accordingly.

I'm away from home for the weekend, so I probably won't be able to
look at your changes before Monday.

Have a nice evening
Lukas