[Pkg-shadow-commits] r340 - trunk/debian

Alexander Gattin arg@online.com.ua
Wed, 6 Jul 2005 02:01:54 +0300


Hi!

On Tue, Jul 05, 2005 at 06:02:27AM +0000, Christian Perrier wrote:
> Minor identing issue
> 
> 
> Modified: trunk/debian/changelog
> ===================================================================
> --- trunk/debian/changelog	2005-07-04 20:25:40 UTC (rev 339)
> +++ trunk/debian/changelog	2005-07-05 06:02:26 UTC (rev 340)
> @@ -43,7 +43,7 @@
>          for rationale see:
>          http://www.opengroup.org/onlinepubs/009695399/utilities/test.html
>        - replaced all unneeded "egrep"s with basic "grep"s
> -      Closes: #256732
> +        Closes: #256732

Hey, this was intentionally there! ;)
Whole changeset was:

    - debian/add-shell.sh, debian/remove-shell.sh, debian/shadowconfig.sh,
      debian/passwd.config, debian/passwd.postinst:
      - checked for bashisms, replaced "#!/bin/bash" with "#!/bin/sh",
        Closes: #315767
      - replaced "test XXX -a YYY" XSI:isms with "test XXX && test YYY",
        for rationale see:
        http://www.opengroup.org/onlinepubs/009695399/utilities/test.html
      - replaced all unneeded "egrep"s with basic "grep"s
      Closes: #256732

This means that

      - checked for bashisms, replaced "#!/bin/bash" with "#!/bin/sh",

_particular change_ closes bug #315767, which is a
subset of bug #256732 which is in turn fixed by the
_whole changeset_, i.e.:

    - debian/add-shell.sh, debian/remove-shell.sh, debian/shadowconfig.sh,
      debian/passwd.config, debian/passwd.postinst:
      ...

That's why it was aligned with "- debian/add-shell.sh, ..." line.
Don't know whether it is appropriate, though...
-- 
WBR,
xrgtn