[Pkg-shadow-commits] r1535 - in upstream/trunk: . src

[nekral-guest at alioth.debian.org]

Author: nekral-guest
Date: 2007-12-28 20:40:59 +0000 (Fri, 28 Dec 2007)
New Revision: 1535

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/src/groupadd.c
Log:
(main): Before pam_end(), the return value of the previous pam API was already
checked. No need to validate it again.


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2007-12-28 20:35:05 UTC (rev 1534)
+++ upstream/trunk/ChangeLog	2007-12-28 20:40:59 UTC (rev 1535)
@@ -8,6 +8,8 @@
 	GID is specified with -g. Simplify find_new_gid accordingly.
 	* src/groupadd.c (process_flags): prefer fail_exit to exit. This avoid
 	an explicit call to audit_logger().
+	* src/groupadd.c (main): Before pam_end(), the return value of the
+	previous pam API was already checked. No need to validate it again.
 
 2007-12-28  Nicolas François  <nicolas.francois at centraliens.net>
 

Modified: upstream/trunk/src/groupadd.c
===================================================================
--- upstream/trunk/src/groupadd.c	2007-12-28 20:35:05 UTC (rev 1534)
+++ upstream/trunk/src/groupadd.c	2007-12-28 20:40:59 UTC (rev 1535)
@@ -564,10 +564,9 @@
 	nscd_flush_cache ("group");
 
 #ifdef USE_PAM
-	if (retval == PAM_SUCCESS) {
-		pam_end (pamh, PAM_SUCCESS);
-	}
+	pam_end (pamh, PAM_SUCCESS);
 #endif				/* USE_PAM */
+
 	exit (E_SUCCESS);
 	/* NOT REACHED */
 }