[Pkg-shadow-commits] r1555 - in upstream/trunk: . src

[nekral-guest at alioth.debian.org]

Author: nekral-guest
Date: 2007-12-29 14:17:06 +0000 (Sat, 29 Dec 2007)
New Revision: 1555

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/src/newusers.c
Log:
Before pam_end(), the return value of the previous
pam API was already checked. No need to validate it again.


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2007-12-29 14:11:54 UTC (rev 1554)
+++ upstream/trunk/ChangeLog	2007-12-29 14:17:06 UTC (rev 1555)
@@ -3,6 +3,8 @@
 	newusers cleanups
 	* src/newusers.c: main() split in new functions: process_flags(),
 	check_flags(), check_perms(), open_files(), and close_files().
+	* src/newusers.c: Before pam_end(), the return value of the previous
+	pam API was already checked. No need to validate it again.
 
 2007-12-29  Nicolas François  <nicolas.francois at centraliens.net>
 

Modified: upstream/trunk/src/newusers.c
===================================================================
--- upstream/trunk/src/newusers.c	2007-12-29 14:11:54 UTC (rev 1554)
+++ upstream/trunk/src/newusers.c	2007-12-29 14:17:06 UTC (rev 1555)
@@ -695,8 +695,7 @@
 	nscd_flush_cache ("group");
 
 #ifdef USE_PAM
-	if (retval == PAM_SUCCESS)
-		pam_end (pamh, PAM_SUCCESS);
+	pam_end (pamh, PAM_SUCCESS);
 #endif				/* USE_PAM */
 
 	exit (0);