[Pkg-shadow-commits] r2249 - in upstream/trunk: . src

[nekral-guest at alioth.debian.org]

Author: nekral-guest
Date: 2008-08-07 08:03:38 +0000 (Thu, 07 Aug 2008)
New Revision: 2249

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/src/usermod.c
Log:
	* src/usermod.c: Report failure to unlock the passwd or shadow
	file to stderr and syslog.

Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2008-08-07 08:03:13 UTC (rev 2248)
+++ upstream/trunk/ChangeLog	2008-08-07 08:03:38 UTC (rev 2249)
@@ -1,5 +1,10 @@
 2008-08-07  Nicolas François  <nicolas.francois at centraliens.net>
 
+	* src/usermod.c: Report failure to unlock the passwd or shadow
+	file to stderr and syslog.
+
+2008-08-07  Nicolas François  <nicolas.francois at centraliens.net>
+
 	* src/newusers.c: Report failure to unlock the passwd or shadow
 	file to stderr and syslog.
 	* src/newusers.c: In case of error when files are open or closed,

Modified: upstream/trunk/src/usermod.c
===================================================================
--- upstream/trunk/src/usermod.c	2008-08-07 08:03:13 UTC (rev 2248)
+++ upstream/trunk/src/usermod.c	2008-08-07 08:03:38 UTC (rev 2249)
@@ -515,18 +515,34 @@
 static void fail_exit (int code)
 {
 	if (gr_locked) {
-		gr_unlock ();
+		if (gr_unlock () == 0) {
+			fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, gr_dbname ());
+			SYSLOG ((LOG_ERR, "failed to unlock %s", gr_dbname ()));
+			/* continue */
+		}
 	}
 #ifdef	SHADOWGRP
 	if (sgr_locked) {
-		sgr_unlock ();
+		if (sgr_unlock () == 0) {
+			fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, sgr_dbname ());
+			SYSLOG ((LOG_ERR, "failed to unlock %s", sgr_dbname ()));
+			/* continue */
+		}
 	}
 #endif
 	if (spw_locked) {
-		spw_unlock ();
+		if (spw_unlock () == 0) {
+			fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, spw_dbname ());
+			SYSLOG ((LOG_ERR, "failed to unlock %s", spw_dbname ()));
+			/* continue */
+		}
 	}
 	if (pw_locked) {
-		pw_unlock ();
+		if (pw_unlock () == 0) {
+			fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, pw_dbname ());
+			SYSLOG ((LOG_ERR, "failed to unlock %s", pw_dbname ()));
+			/* continue */
+		}
 	}
 
 #ifdef WITH_AUDIT
@@ -1121,23 +1137,38 @@
 			fail_exit (E_GRP_UPDATE);
 		}
 #ifdef SHADOWGRP
-		if (is_shadow_grp && (sgr_close () == 0)) {
+		if (is_shadow_grp) {
+			if (sgr_close () == 0) {
 			fprintf (stderr,
 			         _("%s: failure while writing changes to %s\n"),
 			         Prog, sgr_dbname ());
 			fail_exit (E_GRP_UPDATE);
+			if (sgr_unlock () == 0) {
+				fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, sgr_dbname ());
+				SYSLOG ((LOG_ERR, "failed to unlock %s", sgr_dbname ()));
+				/* continue */
+			}
 		}
-		if (is_shadow_grp) {
-			sgr_unlock ();
+#endif
+		if (gr_unlock () == 0) {
+			fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, gr_dbname ());
+			SYSLOG ((LOG_ERR, "failed to unlock %s", gr_dbname ()));
+			/* continue */
 		}
-#endif
-		gr_unlock ();
 	}
 
 	if (is_shadow_pwd) {
-		spw_unlock ();
+		if (spw_unlock () == 0) {
+			fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, spw_dbname ());
+			SYSLOG ((LOG_ERR, "failed to unlock %s", spw_dbname ()));
+			/* continue */
+		}
 	}
-	pw_unlock ();
+	if (pw_unlock () == 0) {
+		fprintf (stderr, _("%s: failed to unlock %s\n"), Prog, pw_dbname ());
+		SYSLOG ((LOG_ERR, "failed to unlock %s", pw_dbname ()));
+		/* continue */
+	}
 
 	pw_locked = false;
 	spw_locked = false;