[Pkg-shadow-commits] r1663 - in upstream/trunk: . src

nekral-guest at alioth.debian.org nekral-guest at alioth.debian.org
Sun Jan 6 12:31:07 UTC 2008


Author: nekral-guest
Date: 2008-01-06 12:31:06 +0000 (Sun, 06 Jan 2008)
New Revision: 1663

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/src/newgrp.c
Log:
* Removed unused gid parameter of syslog_sg().
* The loginname and tty buffers are never changed. Add the const qualifier.


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2008-01-06 12:26:20 UTC (rev 1662)
+++ upstream/trunk/ChangeLog	2008-01-06 12:31:06 UTC (rev 1663)
@@ -1,5 +1,11 @@
 2008-01-06  Nicolas François  <nicolas.francois at centraliens.net>
 
+	* src/newgrp.c: Removed unused gid parameter of syslog_sg().
+	* src/newgrp.c: The loginname and tty buffers are never changed.
+	Add the const qualifier.
+
+2008-01-06  Nicolas François  <nicolas.francois at centraliens.net>
+
 	* src/chpasswd.c, src/chgpasswd.c: The crypt_method string always
 	points to a constant string. Add the const qualifier.
 

Modified: upstream/trunk/src/newgrp.c
===================================================================
--- upstream/trunk/src/newgrp.c	2008-01-06 12:26:20 UTC (rev 1662)
+++ upstream/trunk/src/newgrp.c	2008-01-06 12:31:06 UTC (rev 1663)
@@ -58,7 +58,7 @@
 static void check_perms (const struct group *grp,
                          struct passwd *pwd,
                          const char *groupname);
-static void syslog_sg (gid_t gid, const char *name, const char *group);
+static void syslog_sg (const char *name, const char *group);
 
 /*
  * usage - print command usage message
@@ -194,10 +194,10 @@
  *	The loggout will also be logged when the user will quit the
  *	sg/newgrp session.
  */
-static void syslog_sg (gid_t gid, const char *name, const char *group)
+static void syslog_sg (const char *name, const char *group)
 {
-	char *loginname = getlogin ();
-	char *tty = ttyname (0);
+	const char *loginname = getlogin ();
+	const char *tty = ttyname (0);
 
 	if (loginname != NULL)
 		loginname = xstrdup (loginname);
@@ -547,7 +547,7 @@
 	 */
 #ifdef	USE_SYSLOG
 	if (getdef_bool ("SYSLOG_SG_ENAB")) {
-		syslog_sg (gid, name, group);
+		syslog_sg (name, group);
 	}
 #endif				/* USE_SYSLOG */
 




More information about the Pkg-shadow-commits mailing list