[Pkg-shadow-commits] r3090 - in upstream/trunk: . libmisc

[Nicolas FRANÇOIS]

Author: nekral-guest
Date: 2010-01-24 17:23:42 +0000 (Sun, 24 Jan 2010)
New Revision: 3090

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/libmisc/env.c
Log:
	* libmisc/env.c: Fix sanitize_env() noslash support. This fixes
	Alioth#311740. Thanks to Jason Cassell.


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2010-01-24 17:13:40 UTC (rev 3089)
+++ upstream/trunk/ChangeLog	2010-01-24 17:23:42 UTC (rev 3090)
@@ -1,10 +1,15 @@
 2009-01-24  Nicolas François  <nicolas.francois at centraliens.net>
 
+	* libmisc/env.c: Fix sanitize_env() noslash support. This fixes
+	Alioth#311740.
+
+2009-01-24  Nicolas François  <nicolas.francois at centraliens.net>
+
 	* src/su.c: Do not sanitize the environment. This breaks
 	--preserve-environment. This sanitation was disabled on Debian
 	since quite some time with no reported issues, and sanitize_env()
 	documentation agrees that it should be useless as all modern
-	Unixes will handle setuid executables properly. This Fixes
+	Unixes will handle setuid executables properly. This fixes
 	Alioth#312287.
 
 2009-01-24  Nicolas François  <nicolas.francois at centraliens.net>

Modified: upstream/trunk/libmisc/env.c
===================================================================
--- upstream/trunk/libmisc/env.c	2010-01-24 17:13:40 UTC (rev 3089)
+++ upstream/trunk/libmisc/env.c	2010-01-24 17:23:42 UTC (rev 3090)
@@ -251,7 +251,7 @@
 			if (strncmp (*cur, *bad, strlen (*bad)) != 0) {
 				continue;
 			}
-			if (strchr (*cur, '/') != NULL) {
+			if (strchr (*cur, '/') == NULL) {
 				continue;	/* OK */
 			}
 			for (move = cur; NULL != *move; move++) {