[Pkg-shotwell-maint] Any way to resolve this bug?

David Bremner bremner at debian.org
Sun Dec 9 19:18:32 UTC 2012


To recap, darktable ships an embedded copy of LibRaw with the following
patch applied:

diff --git a/src/external/LibRaw/internal/dcraw_common.cpp b/src/external/
index 20ed524..822b68a 100644
--- a/src/external/LibRaw/internal/dcraw_common.cpp
+++ b/src/external/LibRaw/internal/dcraw_common.cpp
@@ -5904,8 +5904,6 @@ void CLASS apply_tiff()
       || (tiff_bps == 8 && !strstr(make,"KODAK") && !strstr(make,"Kodak")
          !strstr(model2,"DEBUG RAW")))
       is_raw = 0;
-  if(dng_version && max_bps > 16)
-      is_raw = 0;
   for (i=0; i < tiff_nifds; i++)
     if (i != raw && tiff_ifd[i].samples == max_samp && tiff_ifd[i].offset
        tiff_ifd[i].t_width * tiff_ifd[i].t_height / SQR(tiff_ifd[i].bps+1

It seems libraw upstream doesn't want to apply this patch (although I
might misunderstand what Pascal writes there), and darktable won't work
(or at least loses some functionality) without it.

We _could_ hypothetically ask the debian libraw maintainers to apply
this patch, but I could certainly understand them not wanting to do
something that upstream is explicitly declines to do.

I don't see an obvious way forward; some motivated person could pursue
this with libraw upstream I guess.

I think having up to date versions of libraw in debian is less of a
problem, since it is fixable by e.g. NMUing if it becomes a problem.

I have put the Debian libraw maintainers in copy, in case they have any
ideas.

d










More information about the Pkg-shotwell-maint mailing list