[Pkg-shotwell-maint] Bug#811744: libraw: FTBFS with GCC 6: narrowing conversion

[Martin Michlmayr]

Package: libraw
Version: 0.17.1-1
Severity: important
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-6 gcc-6-narrowing

This package fails to build with GCC 6.  GCC 6 has not been released
yet, but it's expected that GCC 6 will become the default compiler for
stretch.

Note that only the first error is reported; there might be more.  You
can find a snapshot of GCC 6 in experimental.  To build with GCC 6,
you can set CC=gcc-6 CXX=g++-6 explicitly.

You may be able to find out more about this issue at
https://gcc.gnu.org/gcc-6/changes.html

> sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
...
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> /bin/bash ./libtool  --tag=CXX   --mode=compile g++ -DPACKAGE_NAME=\"LibRaw\" -DPACKAGE_TARNAME=\"libraw\" -DPACKAGE_VERSION=\"0.17.1\" -DPACKAGE_STRING=\"LibRaw\ 0.17.1\" -DPACKAGE_BUGREPORT=\"info at libraw.org\" -DPACKAGE_URL=\"http://www.libraw.org\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_JPEGLIB_H=1 -DHAVE_JPEGLIB_H=1 -DHAVE_JASPER_JASPER_H=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/local/include -DUSE_JPEG -DUSE_JPEG8 -DUSE_JASPER  -DUSE_LCMS2  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fopenmp -c -o internal/dcraw_common.lo internal/dcraw_common.cpp
> libtool: compile:  g++ -DPACKAGE_NAME=\"LibRaw\" -DPACKAGE_TARNAME=\"libraw\" -DPACKAGE_VERSION=\"0.17.1\" "-DPACKAGE_STRING=\"LibRaw 0.17.1\"" -DPACKAGE_BUGREPORT=\"info at libraw.org\" -DPACKAGE_URL=\"http://www.libraw.org\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_JPEGLIB_H=1 -DHAVE_JPEGLIB_H=1 -DHAVE_JASPER_JASPER_H=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/local/include -DUSE_JPEG -DUSE_JPEG8 -DUSE_JASPER -DUSE_LCMS2 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fopenmp -c internal/dcraw_common.cpp  -fPIC -DPIC -o internal/.libs/dcraw_common.o
> In file included from ./libraw/libraw.h:40:0,
>                  from internal/dcraw_common.cpp:29:
> ./libraw/libraw_datastream.h:96:10: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
>      std::auto_ptr<std::streambuf> f; /* will close() automatically through dtor */
>           ^~~~~~~~
> 
> In file included from /usr/include/c++/6/memory:81:0,
>                  from ./libraw/libraw_datastream.h:38,
>                  from ./libraw/libraw.h:40,
>                  from internal/dcraw_common.cpp:29:
> /usr/include/c++/6/bits/unique_ptr.h:49:28: note: declared here
>    template<typename> class auto_ptr;
>                             ^~~~~~~~
> 
> In file included from ./libraw/libraw.h:40:0,
>                  from internal/dcraw_common.cpp:29:
> ./libraw/libraw_datastream.h:97:10: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
>      std::auto_ptr<std::streambuf> saved_f; /* when *f is a subfile, *saved_f is the master file */
>           ^~~~~~~~
> 
> In file included from /usr/include/c++/6/memory:81:0,
>                  from ./libraw/libraw_datastream.h:38,
>                  from ./libraw/libraw.h:40,
>                  from internal/dcraw_common.cpp:29:
> /usr/include/c++/6/bits/unique_ptr.h:49:28: note: declared here
>    template<typename> class auto_ptr;
>                             ^~~~~~~~
> 
> internal/dcraw_common.cpp: In member function 'void LibRaw::vng_interpolate()':
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '128' from 'int' to 'signed char' inside { } [-Wnarrowing]
>    }, chood[] = { -1,-1, -1,0, -1,+1, 0,+1, +1,+1, +1,0, +1,-1, 0,-1 };
>    ^
> 
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '136' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '128' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '136' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '128' from 'int' to 'signed char' inside { } [-Wnarrowing]
> internal/dcraw_common.cpp:4539:3: error: narrowing conversion of '136' from 'int' to 'signed char' inside { } [-Wnarrowing]
> Makefile:862: recipe for target 'internal/dcraw_common.lo' failed
> make[1]: *** [internal/dcraw_common.lo] Error 1

-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise