[Pkg-silc-devel] Bug#536590: silc-toolkit: FTBFS on GNU/kFreeBSD: missing thread detection

[Cyril Brulebois]

Package: silc-toolkit
Version: 1.1.9-1
Severity: important
Tags: patch
User: glibc-bsd-devel at lists.alioth.debian.org
Usertags: kfreebsd

Hi,

your package FTBFS, given threads aren't detected on GNU/kFreeBSD,
leading to missing SILC_THREADS definition, and then missing functions,
as can be seen there:
| dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below
| dpkg-gensymbols: warning: some symbols disappeared in the symbols file: see diff output below
| dpkg-gensymbols: warning: debian/libsilc-1.1-2/DEBIAN/symbols doesn't match completely debian/libsilc-1.1-2.symbols
| --- dpkg-gensymbols_libsilc-1.1-2_kfreebsd-i386
| +++ dpkg-gensymbolskjDu55	2009-07-06 22:27:06.000000000 +0000
| @@ -254,7 +254,7 @@
|   silc_default_hmacs at Base 1.1.3
|   silc_default_pkcs at Base 1.1.3
|   silc_default_pkcs_alg at Base 1.1.3
| - silc_epoll at Base 1.1.3
| +#MISSING: 1.1.9-1# silc_epoll at Base 1.1.3
|   silc_fd_stream_close at Base 1.1.3
|   silc_fd_stream_create2 at Base 1.1.3
|   silc_fd_stream_create at Base 1.1.3
| @@ -730,6 +730,7 @@
|   silc_pkcs_unregister at Base 1.1.3
|   silc_pkcs_unregister_all at Base 1.1.3
|   silc_pkcs_verify at Base 1.1.3
| + silc_poll at Base 1.1.9-1
|   silc_public_key_payload_decode at Base 1.1.3
|   silc_public_key_payload_encode at Base 1.1.3
|   silc_realloc at Base 1.1.3
| @@ -788,8 +789,8 @@
|   silc_schedule_uninit at Base 1.1.3
|   silc_schedule_unset_listen_fd at Base 1.1.3
|   silc_schedule_wakeup at Base 1.1.3
| - silc_schedule_wakeup_cb at Base 1.1.3
| - silc_schedule_wakeup_init at Base 1.1.3
| +#MISSING: 1.1.9-1# silc_schedule_wakeup_cb at Base 1.1.3
| +#MISSING: 1.1.9-1# silc_schedule_wakeup_init at Base 1.1.3
|   silc_sftp_attr_decode at Base 1.1.3
|   silc_sftp_attr_encode at Base 1.1.3
|   silc_sftp_attr_free at Base 1.1.3
| dh_makeshlibs: dpkg-gensymbols returned exit code 1
| make: *** [binary-arch] Error 1

Full build log:
https://buildd.debian.org/~luk/status/package.php?p=silc-toolkit&suite=unstable

Patch attached (you may want to relibtoolize afterwards).

Once that fixed, there's poll vs. epoll too, as can be seen below:
| --- dpkg-gensymbols_libsilc-1.1-2_kfreebsd-i386
| +++ dpkg-gensymbolsdzMAFK	2009-07-11 14:11:41.000000000 +0200
| @@ -254,7 +254,7 @@
|   silc_default_hmacs at Base 1.1.3
|   silc_default_pkcs at Base 1.1.3
|   silc_default_pkcs_alg at Base 1.1.3
| - silc_epoll at Base 1.1.3
| +#MISSING: 1.1.9-1# silc_epoll at Base 1.1.3
|   silc_fd_stream_close at Base 1.1.3
|   silc_fd_stream_create2 at Base 1.1.3
|   silc_fd_stream_create at Base 1.1.3
| @@ -730,6 +730,7 @@
|   silc_pkcs_unregister at Base 1.1.3
|   silc_pkcs_unregister_all at Base 1.1.3
|   silc_pkcs_verify at Base 1.1.3
| + silc_poll at Base 1.1.9-1
|   silc_public_key_payload_decode at Base 1.1.3
|   silc_public_key_payload_encode at Base 1.1.3
|   silc_realloc at Base 1.1.3
| dh_makeshlibs: dpkg-gensymbols returned exit code 1

AFAICT, epoll is Linux-specific, and “replaced” by poll here. Please
also tweak your symbols file accordingly (for both kfreebsd-{i386,amd64}).

You may want to know that debhelper 7.2.11 has .$os support in addition
to .$arch support, so that you should only need a .kfreebsd file.

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: silc-toolkit+kbsd.diff
Type: text/x-diff
Size: 1055 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-silc-devel/attachments/20090711/06585f63/attachment.diff>