[Pkg-sql-ledger-discussion] LedgerSMB Packaging TODO
Robert James Clay
jame at rocasa.us
Mon Dec 26 00:42:54 UTC 2011
On Thu, 2011-12-22 at 05:43 -0500, Raphael Hertzog wrote:
> [ Reviewing debian/rules ]
>
> 15/ The switch suggested in 1/ will implicitly fix many of the
> problems that I'll raise here but I'll give you them anyway.
> - you should really rely on the upstream "make install" to
> do most of the installation work for you instead of abusing
> dh_install...
I wasn't part of the team at the time, so I don't know why it wasn't
used when they originally started with the packaging. I'll be looking
into using it, for several reasons...
> - all those chmod +x /chmod -x are not very nice, you'd better use
> something like this:
> find . -name '*.pl' -o -name '*.sh' -exec chmod +x '{}' \;
> find . -name '*.pm' -o -name '*.sql' -exec chmod -x '{}' \;
I've made some steps in that direction but I've run in to a couple of
things. The first being that I'm having an issue with getting a multi
expression command line to work, which I need to figure out.
But the other is that some of the '*.pl' files are not scripts, in
that they do not have the usual "#!/usr/bin/perl" line in the file; at
least some of them appear to be Perl package files that are using a
'.pl' extension. Perhaps the LSMB 'make install' handles this better...
> => but it might be the upstream "make install" will put the right
> permissions and that you don't have to muck with the permissions at
> all...
And that's certainly another reason I want to take a look at it.
Jame
More information about the Pkg-sql-ledger-discussion
mailing list