[Pkg-sql-ledger-discussion] Bug#674023: [RFR] templates://ledgersmb/{templates}

Christian PERRIER bubulle at debian.org
Fri May 25 05:10:14 UTC 2012 

Please find, for review, the debconf templates and packages descriptions for the ledgersmb source package.

This review will last from Friday, May 25, 2012 to Monday, June 04, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- ledgersmb.old/debian/templates	2012-05-22 08:27:44.223689383 +0200
+++ ledgersmb/debian/templates	2012-05-25 07:03:17.104480655 +0200
@@ -1,23 +1,24 @@
 Template: ledgersmb/admin_login
 Type: string
 Default: ledgersmb
-_Description: Login for the Database Administrative user:
- Please enter the login of the LedgerSMB Database Administrative user. This
- login is needed for, for instance, running setup.pl in the Web Interface.
- Note that 'ledgersmb' is the standard for this.
+_Description: Database administrative user login:
+ Please enter the login of the LedgerSMB database administrative user. This
+ login is needed, for instance, by setup.pl in the web interface.

Uncapitalize nouns (Das ist nicht gut...:-)). And revert the synopsis
to a quite standard wording for login/password prompts.

Drop the "default is <foo>" sentence, which we always discourage to
use as;.....this is indeed the default setting which will be seen by
usersat first configuration..:)

I'm not entirely convinced that we should mention "setup.pl". Better
talk about the "Configure database" part of the web interface or
something like this.

I also tried to avoid the "for for" construction....Justin will
probably have better suggestions.
 
 Template: ledgersmb/admin_password
 Type: password
 Default: LEDGERSMBINITIAL
-_Description: Password for the Database Administrative user:
- Please enter the password of the LedgerSMB Database Administrative user.
- This password is needed for, for instance, running setup.pl in the Web
- Interface.
+_Description: Database administrative user password:
+ Please enter the password of the LedgerSMB database administrative user.
+ This password is needed, for instance, by setup.pl in the web
+ interface.

About the same changes.

BTW, don't you use a password confirmation template et something to
compare the two passwords entered? That requires some coding in the
config scripts but makes things more robust.

If you want to do so, I have ready standard debconf templates for
this..:-)
(password confirmation template and "passwords do not match" error template)

 
 Template: ledgersmb/debconf_install
 Type: boolean
 Default: false
 _Description: Configure LedgerSMB automatically?
  The configuration program for the package can automatically configure
- LedgerSMB, at least and especially for the LedgerSMB Database User.
-
+ some aspects of LedgerSMB, noticeably the LedgerSMB database user.
+ .
+ More general information about the initial configuration of the application
+ can be found in /usr/share/doc/ledgersmb/README.Debian.

Split in two paragraphs.

Change the "at least and especially" which I suspect to be improvable
English....Turn this into something that also probably improvable
English (Justin?).

--- ledgersmb.old/debian/control	2012-05-22 08:27:44.223689383 +0200
+++ ledgersmb/debian/control	2012-05-25 07:04:05.977736852 +0200
@@ -22,10 +22,10 @@
 Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all
 Conflicts: ledger-smb
 Replaces: ledger-smb
-Description: Financial accounting and ERP program
+Description: financial accounting and ERP program
  LedgerSMB is a double-entry financial accounting and Enterprise Resource
- Planning system which offers Accounts Receivable, Accounts Payable and General
- Ledger tracking as well as inventory control and fixed assets handling. The
+ Planning system which offers "Accounts Receivable", "Accounts Payable" and "General
+ Ledger" tracking as well as inventory control and fixed assets handling. The
  LedgerSMB client can be a web browser or a programmed API call. The goal of the
  LedgerSMB project is to bring high quality ERP and accounting capabilities to
  small and midsize businesses.

Very good package description!

I only found a coupld glitches.

...and now I understand why Raphaël is sponsoring this package..:-)

-- 


-------------- next part --------------
Template: ledgersmb/admin_login
Type: string
Default: ledgersmb
_Description: Database administrative user login:
 Please enter the login of the LedgerSMB database administrative user. This
 login is needed, for instance, by setup.pl in the web interface.

Template: ledgersmb/admin_password
Type: password
Default: LEDGERSMBINITIAL
_Description: Database administrative user password:
 Please enter the password of the LedgerSMB database administrative user.
 This password is needed, for instance, by setup.pl in the web
 interface.

Template: ledgersmb/debconf_install
Type: boolean
Default: false
_Description: Configure LedgerSMB automatically?
 The configuration program for the package can automatically configure
 some aspects of LedgerSMB, noticeably the LedgerSMB database user.
 .
 More general information about the initial configuration of the application
 can be found in /usr/share/doc/ledgersmb/README.Debian.
-------------- next part --------------
--- ledgersmb.old/debian/templates	2012-05-22 08:27:44.223689383 +0200
+++ ledgersmb/debian/templates	2012-05-25 07:03:17.104480655 +0200
@@ -1,23 +1,24 @@
 Template: ledgersmb/admin_login
 Type: string
 Default: ledgersmb
-_Description: Login for the Database Administrative user:
- Please enter the login of the LedgerSMB Database Administrative user. This
- login is needed for, for instance, running setup.pl in the Web Interface.
- Note that 'ledgersmb' is the standard for this.
+_Description: Database administrative user login:
+ Please enter the login of the LedgerSMB database administrative user. This
+ login is needed, for instance, by setup.pl in the web interface.
 
 Template: ledgersmb/admin_password
 Type: password
 Default: LEDGERSMBINITIAL
-_Description: Password for the Database Administrative user:
- Please enter the password of the LedgerSMB Database Administrative user.
- This password is needed for, for instance, running setup.pl in the Web
- Interface.
+_Description: Database administrative user password:
+ Please enter the password of the LedgerSMB database administrative user.
+ This password is needed, for instance, by setup.pl in the web
+ interface.
 
 Template: ledgersmb/debconf_install
 Type: boolean
 Default: false
 _Description: Configure LedgerSMB automatically?
  The configuration program for the package can automatically configure
- LedgerSMB, at least and especially for the LedgerSMB Database User.
-
+ some aspects of LedgerSMB, noticeably the LedgerSMB database user.
+ .
+ More general information about the initial configuration of the application
+ can be found in /usr/share/doc/ledgersmb/README.Debian.
--- ledgersmb.old/debian/control	2012-05-22 08:27:44.223689383 +0200
+++ ledgersmb/debian/control	2012-05-25 07:04:05.977736852 +0200
@@ -22,10 +22,10 @@
 Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all
 Conflicts: ledger-smb
 Replaces: ledger-smb
-Description: Financial accounting and ERP program
+Description: financial accounting and ERP program
  LedgerSMB is a double-entry financial accounting and Enterprise Resource
- Planning system which offers Accounts Receivable, Accounts Payable and General
- Ledger tracking as well as inventory control and fixed assets handling. The
+ Planning system which offers "Accounts Receivable", "Accounts Payable" and "General
+ Ledger" tracking as well as inventory control and fixed assets handling. The
  LedgerSMB client can be a web browser or a programmed API call. The goal of the
  LedgerSMB project is to bring high quality ERP and accounting capabilities to
  small and midsize businesses.
-------------- next part --------------
Source: ledgersmb
Section: web
Priority: optional
Maintainer: Debian LedgerSMB Team <pkg-sql-ledger-discussion at lists.alioth.debian.org>
Uploaders: Robert James Clay <jame at rocasa.us>
Build-Depends: debhelper (>= 8), po-debconf, libmodule-install-perl
Standards-Version: 3.9.3
Homepage: http://www.ledgersmb.org/
Vcs-Svn: svn://svn.debian.org/pkg-sql-ledger/ledger-smb/trunk
Vcs-Browser: http://svn.debian.org/wsvn/pkg-sql-ledger/ledger-smb/trunk

Package: ledgersmb
Architecture: all
Depends: ${perl:Depends}, ${misc:Depends}, perl (>= 5.8.0-1), libconfig-std-perl,
  libconfig-any-perl, libmime-lite-perl, libdbi-perl, libdbd-pg-perl, liberror-perl,
  liblocale-maketext-lexicon-perl (>= 0.62-1), libtemplate-perl (>=2.14-1),
  libhtml-parser-perl, liblog-log4perl-perl, libdatetime-perl, apache2 | httpd-cgi,
  libcgi-simple-perl, libfile-mimeinfo-perl, libio-stringy-perl,
  postgresql-client, postgresql-contrib, dbconfig-common
Recommends: default-mta | mail-transport-agent, texlive-latex-recommended, libopenoffice-oodoc-perl,
  libmath-bigint-gmp-perl, libparse-recdescent-perl
Suggests: postgresql, lpr, libnet-tclink-perl, latex-cjk-all
Conflicts: ledger-smb
Replaces: ledger-smb
Description: financial accounting and ERP program
 LedgerSMB is a double-entry financial accounting and Enterprise Resource
 Planning system which offers "Accounts Receivable", "Accounts Payable" and "General
 Ledger" tracking as well as inventory control and fixed assets handling. The
 LedgerSMB client can be a web browser or a programmed API call. The goal of the
 LedgerSMB project is to bring high quality ERP and accounting capabilities to
 small and midsize businesses.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-sql-ledger-discussion/attachments/20120525/d9bf441c/attachment-0001.pgp>

More information about the Pkg-sql-ledger-discussion mailing list