[pkg-squid-devel] Bug #768170 - dist upgrade issues in 3.4.8-2 and older

[Luigi Gangitano]

Hi,

Sorry for the almost-too-late reply. I just pushed an updated 3.4.8-3 with Santiago’s suggestions in: check for acl manager definition and sed string updated to match whitespace at the beginning of the line.

I also changed the backup file name to squid.conf.pre_3.4_upgrade so that is clear which version made the change.

I’m uploading this version right now and asking for unblock. Let’s hope for the best. ;-)

Regards,

L

> Il giorno 26/nov/2014, alle ore 11:02, Amos Jeffries <squid3 at treenet.co.nz> ha scritto:
> 
> Firmato Parte PGP
> Luigi, how would you like to proceed on this?
> 
> Amos
> 
> On 11/11/2014 11:29 a.m., Santiago Garcia Mantinan wrote:
> >>> I've added a script update to git repository that drops the
> >>> problem ACL definition on upgrades (and restores if aborted).
> >
> > Just a couple of notes on this. You do the filtering even if this
> > acl is not there, I think we could do a grep to see if an
> > uncommented "acl manager" exists and only if it does, do the dirty
> > work.
> >
> > About the sed expresion...
> >
> > sed -e 's/acl\ manager\ .*//'
> > </etc/squid3/squid.conf.upgrade-backup >/etc/squid3/squid.conf
> >
> > Does the work even if the line is commented, what I'd do is
> > something like this:
> >
> > sed -e "s/^\([ \t]*acl manager .*\)/# commented out on upgrade:
> > \1/"
> >
> > And last, about the extension of the file, there is .dpkg-old, for
> > example right now on my server...
> >
> > /etc/ca-certificates.conf.dpkg-old
> >
> > Which is used by dpkg to store old config files, don't know if it
> > would make sense to use that extension or how is that extension
> > supposed to work, but maybe it makes sense to investigate that
> > before adding some new extension.
> >
> >> I checked your patch and would like to investigate a couple of
> >> details:
> >>
> >> - is this the only configuration file conflict when upgrading
> >> from stock wheezy? Can we add a list of conflicting config
> >> directives to NEWS.Debian? - your patch leaves the
> >> squid.conf.upgrade-backup file in place even after successful
> >> upgrade. Shall we remove it?
> >
> > On the second note, the .dpkg-old files are left there on upgrades,
> > I think our case is just the same, but I don't know if that is
> > supposed to be created directly by dpkg or we can create them with
> > a script, or maybe we should ask dpkg to do the job for us :-?
> >
> >>> If you guys can check that over I think this bug qualifies for
> >>> RC status.
> >> I agree and would like to upload a fix as soon as possible. Do we
> >> want any other fix in it?
> >
> > Well, I didn't want to bug it as RC just in case it was something
> > wrong just with me :-)
> >
> > Regards.
> >
> 
> 
> _______________________________________________
> pkg-squid-devel mailing list
> pkg-squid-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-squid-devel
> 

--
Luigi Gangitano -- <luigi at debian.org> -- <gangitano at lugroma3.org>
GPG: 1024D/924C0C26: 12F8 9C03 89D3 DB4A 9972  C24A F19B A618 924C 0C26
GPG: 4096R/2BA97CED: 8D48 5A35 FF1E 6EB7 90E5  0F6D 0284 F20C 2BA9 7CED