[Pkg-symfony-maint] Integrating propel with phing dependency

[Federico Giménez Nieto]

Hi John, here come some comments from my side about your package:

-I'm not able to build it, here are the steps followed:

# git clone ssh://fgimenez-guest@git.debian.org/git/pkg-symfony/propel.git
# dpkg-buildpackage -rfakeroot -sa

and i get:

Applying patch debian-changes-1.4-1
patching file generator/bin/propel-gen
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- rejects in file generator/bin/propel-gen
Patch debian-changes-1.4-1 can be reverse-applied
dh_quilt_patch: quilt --quiltrc /dev/null push -a || test $? = 2
returned exit code 1
make: *** [build] Error 9
dpkg-buildpackage: error: debian/rules build gave error exit status 2

I seems that you have put in the repository the patched
generator/bin/propel-gen file, not the upstream's original one.
Moreover, instead of letting debhelper create the patch, you should do
it by yourself and place comments about the motivation of the chages
made.

-Since it is not being used, you should remove the
debian/README.Debian file. Moreover, as you are using 3.0 (quilt)
source format, debian/README.source can be removed as well.

-debian/changelog: the 'Initial release' line is enough for this version.

-debian/control:
    -Again, as you are using 3.0 (quilt) source format you can remove
the build dependency on quilt
    -In debian environment open-source is always implied, you can
remove that from the description field.

-debian/copyright: it seems that there are some copyright references
that are not included in this file, from the source directory run:

# grep -r copyright .

-debian/rules:
    -For the same reason as above you can remove the quilt reference
    -Instead of using an override and stating all the required install
commands you can create a 'install' file, see 'man dh_install'

-About the repository layout there is no need to keep these files
there: debian/docs, debian/files, debian/propel.debhelper.log,
debian/propel.substvars. You should remove also the .pc directory.

Let me know if i can be of some help with any of these. Once built,
you could also try to upload the package to mentors, see [1]

Cheers,
Federico

[1] http://mentors.debian.net

2010/4/17 Federico Gimenez Nieto <fgimenez at coit.es>:
> Hi John,
>
> On Fri, 2010-04-16 at 16:37 -0500, John Arevalo wrote:
>>
>> Hi, I've modified deb package with advices you have given me, please
>> check it.
>>
>
> Of course, i'll ping the list when done.
>
> Thanks for your work :), cheers
> Federico
>



-- 
Federico Giménez Nieto
fgimenez at coit.es