[Pkg-sympa-devel] Bug#653265: VERP never gets used even enabled in configuration

[Phil Vandry]

Package: sympa
Version: 6.1.7~dfsg-2
Severity: normal
Tags: patch

When configured for VERP (variable envelope return path) the outgoing
email envelope sender is supposed to be customized for each recipient.
Due to a bug in the code, the special return path is never applied,
and the email goes out with the list's generic envelope sender
<listname-owner at domain>.

This bug was discovered in version 6.1.1~dfsg-2 (Ununtu natty) but by
inspection of the source code the problem is still present in 6.1.7 .
Due to this part of the code having been rewritten for the upcoming
6.2 version, the problem is NOT present in upstream's 6.2a.4 .

Fix:

diff --git a/src/bulk.pl.in b/src/bulk.pl.in
index d5464e8..4479e4f 100644
--- a/src/bulk.pl.in
+++ b/src/bulk.pl.in
@@ -267,7 +267,7 @@ while (!$end) {
 	    foreach $rcpt (@rcpts) {
 		my $return_path = $bulk->{'returnpath'};
 		if ($bulk->{'verp'}) {
-		    my $return_path = $rcpt;
+		    $return_path = $rcpt;
 		    $return_path =~ s/\@/\=\=a\=\=/; 
 		    $return_path = "$Conf::Conf{'bounce_email_prefix'}+$return_path\=\=$bulk->{'listname'}\@$bulk->{'robot'}"; 
 		}

-Phil