[Pkg-telepathy-commits] [libnice] 123/265: socket: Add note that the packet dropping in tcp-bsd is broken behavior

[Simon McVittie]

This is an automated email from the git hooks/post-receive script.

smcv pushed a commit to branch debian
in repository libnice.

commit ce90943f9538fa037f56d40972593c5911b7a1dc
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Fri Jan 24 03:02:38 2014 -0500

    socket: Add note that the packet dropping in tcp-bsd is broken behavior
---
 socket/tcp-bsd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/socket/tcp-bsd.c b/socket/tcp-bsd.c
index 6e54b22..5792129 100644
--- a/socket/tcp-bsd.c
+++ b/socket/tcp-bsd.c
@@ -285,6 +285,9 @@ socket_send_message (NiceSocket *sock, const NiceOutputMessage *message)
       ret = message->length;
     }
   } else {
+    /* FIXME: This dropping will break http/socks5/etc
+     * We probably need a way to the upper layer to control reliability
+     */
     /* If the queue is too long, drop whatever packets we can. */
     if (g_queue_get_length (&priv->send_queue) >= MAX_QUEUE_LENGTH) {
       guint peek_idx = 0;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-telepathy/libnice.git