[Pkg-telepathy-commits] [libnice] 243/265: discovery: Remove never used and leaked msn_turn_* fields in CandidateRefresh

Simon McVittie smcv at debian.org
Wed May 14 12:05:13 UTC 2014


This is an automated email from the git hooks/post-receive script.

smcv pushed a commit to branch debian
in repository libnice.

commit 6b661b27fa0f02374d87d6bf58f8faee683f8946
Author: Olivier Crête <olivier.crete at collabora.com>
Date:   Tue Apr 22 16:47:36 2014 -0400

    discovery: Remove never used and leaked msn_turn_* fields in CandidateRefresh
---
 agent/conncheck.c | 6 ++----
 agent/discovery.h | 2 --
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/agent/conncheck.c b/agent/conncheck.c
index 90d5bd0..376fb18 100644
--- a/agent/conncheck.c
+++ b/agent/conncheck.c
@@ -818,10 +818,8 @@ static void priv_turn_allocate_refresh_tick_unlocked (CandidateRefresh *cand)
 
   if (turn_compat == STUN_USAGE_TURN_COMPATIBILITY_MSN ||
       turn_compat == STUN_USAGE_TURN_COMPATIBILITY_OC2007) {
-    g_free (cand->msn_turn_username);
-    g_free (cand->msn_turn_password);
-    cand->msn_turn_username = username;
-    cand->msn_turn_password = password;
+    g_free (username);
+    g_free (password);
   }
 
   nice_debug ("Agent %p : Sending allocate Refresh %zd", cand->agent,
diff --git a/agent/discovery.h b/agent/discovery.h
index b72e941..973702e 100644
--- a/agent/discovery.h
+++ b/agent/discovery.h
@@ -77,8 +77,6 @@ typedef struct
   StunAgent stun_agent;
   GSource *timer_source;
   GSource *tick_source;
-  uint8_t *msn_turn_username;
-  uint8_t *msn_turn_password;
   StunTimer timer;
   uint8_t stun_buffer[STUN_MAX_MESSAGE_SIZE];
   StunMessage stun_message;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-telepathy/libnice.git



More information about the Pkg-telepathy-commits mailing list