[Pkg-tpctl-devel] Re: status of the thinkpad-source package

[martin f krafft]

You'll get Eduard's mail when Thomas let's it through moderation.
In the mean time, his post is here:

  http://madduck.net/~madduck/scratch/mutt-lapse-1000-19885-0

also sprach Eduard Bloch <edi at gmx.de> [2006.07.30.2323 +0100]:
> What do you try to achieve with stamp files if they have no meaning and
> are apparently not removed in the *clean rules?

As you suggested, I am trying to make things work and will clean up
later. The stamp files are not needed at all, but they are properly
removed in the clean rules:

lapse:..thinkpad.trunk/debian> grep -- -stamp rules rules.modules
[abbreviated output]
rules:configure-stamp:
rules:build-indep-stamp:
rules:  rm -f build-arch-stamp build-indep-stamp configure-stamp
rules.modules:configure-stamp: debian/control debian/postinst debian/postrm
rules.modules:build-stamp: kdist_config
rules.modules:  rm -f configure-stamp build-stamp

> > However, when I run kdist_build, which causes kdist_config to be run
> > and all modules to be compiled, module-assistant calls
> > 
> >   /usr/bin/make -f debian/rules kdist_clean kdist_config binary-modules
> > 
> > and for some reason, make says
> > 
> >   make[1]: Nothing to be done for `kdist_config'.
> 
> Your kdist_config rule is "not well designed":
> 
> configure-stamp: debian/control debian/postinst debian/postrm

Well, configure-stamp is what's missing. kdist_clean had just been
called and it removed configure-stamp, so calling kdist_clean
*really* should remake the stamp.

> What should it be good for? Every time one of the files change,
> configure-stamp shall ge generated? Ok, but if none of them changes and
> package is just rebuilt?

I only use the make syntax for implcitly ensure that these files are
processed. I don't expect them to change. I expect the configure
target to be rerun because configure-stamp vanished.

But I understand now what you are saying: I expected
a missing configure-stamp to remake the debian/control file, which
obviously won't happen unless debian/control.in changed.

I'll fix that.

But let me ask why kdist_build bothers to call kdist_clean?

> There is no orig tarball and your copyright file does not show me
> a download location. Sorry, WTF?

Fixed.

> > Anyway, now you all know what's up and hopefully Eduard can help.
> > 
> > The code is 6.0-1 already, but I have not looked at any bugs or the
> > changes suggested by Thomas Hood.
> 
> I do not see what this hocus pocus should be good for. Sorry,
> guys, I do not like what you do (or someone did before you).
> I suggest you make the stuff work FIRST and then reconsider what
> cosmetic changes are good for _before_ doing them.

I don't know what you're trying to say. I am simply trying to make
thinkpad-source work with module-assistant, and it's proven to be
a massively difficult task. I could not find any proper
documentation or HOWTO, so I had to look at what other packages are
doing, and it's mostly just hacks all over the place.

I wish someone were to show me how to properly create -modules
packages. I wish there were some document out there that would
explain it once and for all.

> Eg.  what is a changelog good for if it does not document changes?
> (unlike the source' package changelog).

The changelog documents a change, namely that the package was
transformed from -source to the -modules package. This is a required
step, isn't it?

Or what exactly am I doing wrong?

-- 
 .''`.     martin f. krafft <madduck at debian.org>
: :'  :    proud Debian developer and author: http://debiansystem.info
`. `'`
  `-  Debian - when you have better things to do than fixing a system
 
"in diving to the bottom of pleasure
 we bring up more gravel than pearls."
                                                   -- honoré de balzac
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature (GPG/PGP)
Url : http://lists.alioth.debian.org/pipermail/pkg-tpctl-devel/attachments/20060730/5e000524/attachment.pgp