[Pkg-uml-devel] Re: [Pkg-uml-commit] r89 - trunk/src/rootstrap

[Mattia Dongili]

On Tue, May 23, 2006 at 02:53:10PM +0000, Stefano Melchior wrote:
> Author: stex-guest
> Date: 2006-05-23 14:53:09 +0000 (Tue, 23 May 2006)
> New Revision: 89
> 
> Modified:
>    trunk/src/rootstrap/rootstrap
>    trunk/src/rootstrap/rootstrap.conf
> Log:
> In case you need rootstrap to work via console con0=fd:0, not con0=fd:0,fd:1  and con=pts

why would you want that? Rootstrap doesn't spawn any console so the
"con" argument is useless.

> Modified: trunk/src/rootstrap/rootstrap
> ===================================================================
> --- trunk/src/rootstrap/rootstrap	2006-05-23 10:28:03 UTC (rev 88)
> +++ trunk/src/rootstrap/rootstrap	2006-05-23 14:53:09 UTC (rev 89)
> @@ -90,7 +90,7 @@
>  
>  umlargs.extend(umlargs_extra)
>  
> -umlargs.extend(['con0=fd:0,fd:1',
> +umlargs.extend(['con0=fd:0',
>                  'con=pts',

either we allow the user specify the full console type (useless, see
above) or the removal of the "fd:1" sounds pretty wrong.

> Modified: trunk/src/rootstrap/rootstrap.conf

ohohoh! Don't commit your personal configuration :)
please revert to the previous version of this file (I'd revert the full
commit actually).

[...]
>  #
>  # Debian module
>  #
>  [debian]
> -dist=woody
> +dist=sarge

The only worth change is this, but I'd use the "stable" name for the
distribution, so we won't have problems during the freeze.

-- 
mattia
:wq!