[Pkg-uml-devel] Patch: enables to run rootstrap in the background

[Mattia Dongili]

On Sat, Nov 18, 2006 at 11:44:10PM +0200, shaulka at 012.net.il wrote:
>   On Saturday, November 18, 2006 9:54 pm, Mattia Dongili wrote:
> 
> > Anyway, since uml already has some way of avoiding the tty usage 
> > why not
> > simply use "con=null con0=null" when rootstrap is not controlling the
> > terminal?
> > 
> 
>   The fact that rootstrap has no controlling terminal is equivalent to 
> os.tcgetpgrp(sys.std{in,out}.fileno()) != os.getpgrp(). However if you will
> always specify con=null when that happens you will include constructs
> like
> 
>        rootstrap -o log &
>   or
>        rootstrap > log &
> 
> , thus preveting logging much of the action. Aren't rootstrap modules
> doing much of  the work from inside uml? In addition, other then the

Yes, they are (_all_ of their action). 

> resources for the pipe and the sink file, I believe that my patch gives
> the same results as con=null when no logging is attempted.

Yes, you are right, I'll apply your patch with some minor modifications
to indentation and maybe some comment :)

>   As an aside, doesn't `con0=null' redundant when one specifies
> `con=null'?

Yes, it is, but it was just meant to parametrize the current
code with uses "con=pts con0=fd:0,fd:1", kind of

con='pts'
con0='fd:0,fd:1'

if os.tcgetpgrp(sys.std{in,out}.fileno()) != os.getpgrp():
	con='null'
	con0='null'

[launch UML]

-- 
mattia
:wq!