[Pkg-utopia-commits] r3244 - in /packages/unstable/hal/debian: changelog patches/21_fix_segfault_in_hal_util_get_last_element.patch patches/series

[biebl at users.alioth.debian.org]

Author: biebl
Date: Thu Nov  5 11:48:08 2009
New Revision: 3244

URL: http://svn.debian.org/wsvn/pkg-utopia/?sc=1&rev=3244
Log:
Fix segfault in hal_util_get_last_element

* debian/patches/21_fix_segfault_in_hal_util_get_last_element.patch
  - Validate input before passing it to strlen which fixes a segfault in
    hal_util_get_last_element. (Closes: #531383)

Added:
    packages/unstable/hal/debian/patches/21_fix_segfault_in_hal_util_get_last_element.patch
Modified:
    packages/unstable/hal/debian/changelog
    packages/unstable/hal/debian/patches/series

Modified: packages/unstable/hal/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-utopia/packages/unstable/hal/debian/changelog?rev=3244&op=diff
==============================================================================
--- packages/unstable/hal/debian/changelog (original)
+++ packages/unstable/hal/debian/changelog Thu Nov  5 11:48:08 2009
@@ -4,6 +4,9 @@
     the acl package.
   * Disable multimedia key remapping which is managed by udev. Drop build
     dependency on gperf.
+  * debian/patches/21_fix_segfault_in_hal_util_get_last_element.patch
+    - Validate input before passing it to strlen which fixes a segfault in
+      hal_util_get_last_element. (Closes: #531383)
 
  -- Michael Biebl <biebl at debian.org>  Wed, 04 Nov 2009 20:13:06 +0100
 

Added: packages/unstable/hal/debian/patches/21_fix_segfault_in_hal_util_get_last_element.patch
URL: http://svn.debian.org/wsvn/pkg-utopia/packages/unstable/hal/debian/patches/21_fix_segfault_in_hal_util_get_last_element.patch?rev=3244&op=file
==============================================================================
--- packages/unstable/hal/debian/patches/21_fix_segfault_in_hal_util_get_last_element.patch (added)
+++ packages/unstable/hal/debian/patches/21_fix_segfault_in_hal_util_get_last_element.patch Thu Nov  5 11:48:08 2009
@@ -1,0 +1,28 @@
+From d2a8666f14220d1eeffba79933b8fdf06b44206c Mon Sep 17 00:00:00 2001
+From: Michael Biebl <biebl at debian.org>
+Date: Thu, 5 Nov 2009 03:08:26 +0100
+Subject: [PATCH 1/3] Fix a crasher in hal_util_get_last_element
+
+http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=531383
+---
+ hald/util.c |    4 ++++
+ 1 files changed, 4 insertions(+), 0 deletions(-)
+
+diff --git a/hald/util.c b/hald/util.c
+index 7fa3011..5986686 100644
+--- a/hald/util.c
++++ b/hald/util.c
+@@ -106,6 +106,10 @@ hal_util_get_last_element (const gchar *s)
+ 	int len;
+ 	const gchar *p;
+ 
++	if (s == NULL) {
++		return NULL;
++	}
++
+ 	len = strlen (s);
+ 	for (p = s + len - 1; p > s; --p) {
+ 		if ((*p) == '/')
+-- 
+1.6.5.2
+

Modified: packages/unstable/hal/debian/patches/series
URL: http://svn.debian.org/wsvn/pkg-utopia/packages/unstable/hal/debian/patches/series?rev=3244&op=diff
==============================================================================
--- packages/unstable/hal/debian/patches/series (original)
+++ packages/unstable/hal/debian/patches/series Thu Nov  5 11:48:08 2009
@@ -1,5 +1,6 @@
 10-no-polkit-policy-file-validate-check.patch
 20_cpufreq_warning_message_fix.patch
+21_fix_segfault_in_hal_util_get_last_element.patch
 30_mount_relatime.patch
 40_readme_remove_hacking.patch
 50_kfreebsd.patch