[Pkg-varnish-devel] Bug#645688: init.d/varnishncsa unbalanced braces on pidfile expansion

[Jeroen Pulles]

Package: varnish
Version: 3.0.1-2
Severity: normal

Dear Maintainer,

The braces on the $PIDFILE in the varnishncsa init.d file are not balanced on
DAEMON_OPTS. This variable is only used on startup, the other functions use
$PIDFILE directly, and as a result don't find the actual
"/var/run/varnishncsa/varnishncsa.pid}" file. 

kind regards,
Jeroen Pulles

--- varnish.varnishncsa.init.orig       2011-10-17 21:55:48.000000000 +0200
+++ varnish.varnishncsa.init    2011-10-17 21:57:20.000000000 +0200
@@ -20,7 +20,7 @@
 PIDFILE=/var/run/$NAME/$NAME.pid
 LOGFILE=/var/log/varnish/varnishncsa.log
 USER=varnishlog
-DAEMON_OPTS="-a -w ${LOGFILE} -D -P $PIDFILE}"
+DAEMON_OPTS="-a -w ${LOGFILE} -D -P ${PIDFILE}"
 
 # Include defaults if available
 if [ -f /etc/default/$NAME ] ; then


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.0.0-1-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages varnish depends on:
ii  adduser               3.113          
ii  gcc                   4:4.6.1-2      
ii  libc6                 2.13-21        
ii  libc6-dev [libc-dev]  2.13-21        
ii  libedit2              2.11-20080614-3
ii  libncurses5           5.9-2          
ii  libpcre3              8.12-4         
ii  libvarnishapi1        3.0.1-2        

varnish recommends no packages.

Versions of packages varnish suggests:
pn  varnish-doc  <none>

-- Configuration Files:
/etc/default/varnish changed [not included]
/etc/default/varnishncsa changed [not included]
/etc/init.d/varnishncsa changed [not included]
/etc/logrotate.d/varnish changed [not included]
/etc/varnish/default.vcl changed [not included]

-- no debconf information