[Pkg-varnish-devel] Bug#754967: varnish: Varnish init.d script silently ignores failed reload-vcl

[Paweł Sadowski]

Source: varnish
Version: 4.0.1-1 3.0.2-2+deb7u1
Severity: normal

Hi,

When trying to automate VCL deployment with Puppet I hit a bug in Varnish init.d script.
When called with 'reload' argument it always returns 0, disregarding reload-vcl exit code
due to 'exit 0' at the end of this script.

I can't think of any reason why this has been added there.

'exit 0' is present in 3.x and 4.x packages.


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pl_PL.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash