[Pkg-varnish-devel] Bug#789659: varnish: dumps compiled VCL to systemd journal due to ExecStartPre running varnishd -C

[Paul Wise]

Package: varnish
Version: 4.0.2-1
Severity: minor
X-Debbugs-CC: debian-admin at lists.debian.org
User: debian-admin at lists.debian.org
Usertags: needed-by-DSA-Team

The varnish.service file used under systemd contains the following
line. The -C means that when the varnish service starts, it will dump
the full compiled VCL to the systemd journal. This is annoying when
trying to debug other problems with varnish (like #789658). I assume
this is meant as a check of the VCL file. It would be great if upstream
could implement a check that only dumps errors to stdout/stderr instead
of compiled VCL. Alternatively, the stdout of the command should be
sent to /dev/null like the init script does. 

Symptoms:

sudo journalctl -u varnish
-- Logs begin at Sun 2015-06-07 11:14:37 UTC, end at Tue 2015-06-23 07:37:44 UTC. --
Jun 07 11:14:51 lw07 varnishd[1079]: /* ---===### include/vcl.h ###===--- */
Jun 07 11:14:51 lw07 varnishd[1079]: /*
Jun 07 11:14:51 lw07 varnishd[1079]: * NB:  This file is machine generated, DO NOT EDIT!
Jun 07 11:14:51 lw07 varnishd[1079]: *
Jun 07 11:14:51 lw07 varnishd[1079]: * Edit and run generate.py instead
Jun 07 11:14:51 lw07 varnishd[1079]: */
Jun 07 11:14:51 lw07 varnishd[1079]: struct vrt_ctx;
...
..
.

Problematic file:

/lib/systemd/system/varnish.service

Problematic line:

ExecStartPre=/usr/sbin/varnishd -C -f /etc/varnish/default.vcl

Hypothetical fix:

ExecStartPre=/usr/sbin/varnishd --check -f /etc/varnish/default.vcl

Workaround fix:

ExecStartPre=sh -c 'exec /usr/sbin/varnishd -C -f /etc/varnish/default.vcl > dev/null'

Init script:

configtest() {
    $DAEMON ${DAEMON_OPTS} -C -n /tmp > /dev/null
}

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-varnish-devel/attachments/20150623/e9ee66e2/attachment.sig>