[Pkg-varnish-devel] Bug#871553: systemd service doesn't honour /etc/default/varnish

[David Paleino]

Source: varnish
Version: 5.0.0-7.1
Severity: normal
Tags: patch

Hello,

today I installed varnish on my production server and, while trying to
configure it, it inexplicably failed to follow the options given
in /etc/default/varnish.

I found out that the mentioned file is only honoured by /etc/init.d/varnish;
while /lib/systemd/system/varnish.service simply provides a (reasonable!) set
of defaults.

See the attached proposed patch. A couple of notes on that, though:

1) regarding VARNISH_STORAGE_FILE, in /etc/default/varnish it uses $INSTANCE,
which in turn is $(uname -n). I don't really know how to launch subscripts from
systemd service files, so I simply put "instance" there, please have a look
whether it's feasible or not.

2) always regarding the storage type, i.e. the "-s" switch of varnishd,
in /etc/default/varnish and varnish.service two different defaults are used.
Please settle on one (the former uses file, the latter uses malloc).

Have a nice day,
David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: varnish.patch
Type: text/x-patch
Size: 1160 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-varnish-devel/attachments/20170809/221c1085/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: Firma digitale OpenPGP
URL: <http://lists.alioth.debian.org/pipermail/pkg-varnish-devel/attachments/20170809/221c1085/attachment-0001.sig>