Bug#219386: marked as forwarded (E91: 'shell' option is empty)

[Debian Bug Tracking System]

Your message dated Sun, 16 Oct 2005 18:27:50 +0200
with message-id <20051016162750.GA28985 at sockmel.bononia.it>
has caused the Debian Bug report #219386,
regarding E91: 'shell' option is empty
to be marked as having been forwarded to the upstream software
author(s) bram at moolenaar.net.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---------------------------------------
Received: (at 219386-forwarded) by bugs.debian.org; 16 Oct 2005 16:27:54 +0000
>From zack at bononia.it Sun Oct 16 09:27:54 2005
Return-path: <zack at bononia.it>
Received: from sockmel.bononia.it [194.242.226.39] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1ERBMY-00071S-00; Sun, 16 Oct 2005 09:27:54 -0700
Received: by sockmel.bononia.it (Postfix, from userid 1004)
	id 1334156D4A; Sun, 16 Oct 2005 18:27:50 +0200 (CEST)
Date: Sun, 16 Oct 2005 18:27:50 +0200
From: Stefano Zacchiroli <zack at debian.org>
To: bram at moolenaar.net
Cc: 219386-forwarded at bugs.debian.org,
	219386-submitter at bugs.debian.org
Subject: system() failing when SHELL is empty
Message-ID: <20051016162750.GA28985 at sockmel.bononia.it>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="opJtzjQTFsWo+cga"
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
Delivered-To: 219386-forwarded at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02


--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Bram,
  a Debian user reported a problem origined by the choice of setting vim
variable 'shell' to the value of the environment variable SHELL, if
defined.

Unfortunately, if SHELL is set to the empty string, vim system()
function complains about empty 'shell' variable and doesn't work
anymore.

What do you think of treating the case of empty SHELL variable as if no
SHELL variable is defined at all? The attached patch implement this
behaviour.

TIA,
Cheers.

-- 
Stefano Zacchiroli  --  Master in Computer Science @ Uni. Bologna, Italy
zack@{cs.unibo.it,debian.org,bononia.it}  -  http://www.bononia.it/zack/
"  I know you believe you understood what you think I said, but I am not
sure you realize that what you heard is not what I meant!  " -- G.Romney

--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="303_option.c.diff"

diff -urN vim64/src/option.c vim64.new/src/option.c
--- vim64/src/option.c	2005-10-08 16:27:46.000000000 +0200
+++ vim64.new/src/option.c	2005-10-16 17:56:15.007237360 +0200
@@ -2512,7 +2512,8 @@
 # endif
 #endif
        )
-	set_string_default("sh", p);
+	if (strlen(p) != 0)
+	    set_string_default("sh", p);
 
 #ifdef FEAT_WILDIGN
     /*

--opJtzjQTFsWo+cga--