Bug#348170: marked as done (vim: FTBFS on hurd-i386: Unconditional use of system limit macro)

Debian Bug Tracking System owner at bugs.debian.org
Sun Jan 15 19:48:27 UTC 2006


Your message dated Sun, 15 Jan 2006 11:32:24 -0800
with message-id <E1EyDc0-0007o1-Mg at spohr.debian.org>
and subject line Bug#348170: fixed in vim 1:6.4-006+2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Jan 2006 12:44:16 +0000
>From mbanck at gmx.net Sun Jan 15 04:44:16 2006
Return-path: <mbanck at gmx.net>
Received: from mail.gmx.de ([213.165.64.21] helo=mail.gmx.net)
	by spohr.debian.org with smtp (Exim 4.50)
	id 1Ey7F1-00075B-SR
	for submit at bugs.debian.org; Sun, 15 Jan 2006 04:44:16 -0800
Received: (qmail invoked by alias); 15 Jan 2006 12:43:44 -0000
Received: from ppp-82-135-10-31.mnet-online.de (EHLO localhost.localdomain) [82.135.10.31]
  by mail.gmx.net (mp018) with SMTP; 15 Jan 2006 13:43:44 +0100
X-Authenticated: #686195
Received: from mbanck by localhost.localdomain with local (Exim 4.52)
	id 1Ey7EU-0002pP-Gw
	for submit at bugs.debian.org; Sun, 15 Jan 2006 13:43:42 +0100
Date: Sun, 15 Jan 2006 13:43:42 +0100
From: mbanck at debian.org
To: submit at bugs.debian.org
Subject: vim: FTBFS on hurd-i386: Unconditional use of system limit macro
Message-ID: <20060115124342.GB8356 at chemicalconnection.dyndns.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="FL5UXtIhxfXey3p5"
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
X-Y-GMX-Trusted: 0
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-5.4 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	NO_REAL_NAME,RCVD_IN_SORBS autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02


--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: vim
Version: 1:6.4-004+2
Severity: important
Tags: patch

Hi,

your package failed to autobuild on hurd-i386:

Automatic build of vim_1:6.4-004+2 on beethoven by sbuild/hurd-i386 79
Build started at 20051221-1255
******************************************************************************
Checking available source versions...
Fetching source files...
Reading Package Lists...
Building Dependency Tree...
Need to get 5918kB of source archives.
Get:1 http://people.debian.org unstable/main vim 1:6.4-004+2 (dsc) [1353B]
Get:2 http://people.debian.org unstable/main vim 1:6.4-004+2 (tar) [5741kB]
Get:3 http://people.debian.org unstable/main vim 1:6.4-004+2 (diff) [175kB]
Fetched 5918kB in 33s (177kB/s)
Download complete and in download only mode
** Using build dependencies supplied by package:
Build-Depends: debhelper (>= 4.2.21), dpkg (>> 1.7.0), bzip2, perl (>= 5.6), libgpmg1-dev [!hurd-i386] | not+linux-gnu, libperl-dev (>= 5.6), tcl8.4-dev [!hurd-i386] | tcl8.3-dev [!hurd-i386], python-dev, libncurses5-dev, ruby, ruby1.8-dev | ruby-dev, libgtk2.0-dev (>= 2.2) | libgtk1.2-dev, libgnomeui-dev [!hurd-i386], lesstif2-dev
Build-Conflicts: libperl-dev (= 5.8.4-1)
** Filtered missing central deps that are dependencies of or provide build-deps:
xlibs-dev (>> 4.1.0), zlib1g-dev (>= 1:1.2.1)
[...]
Checking correctness of source dependencies...
Toolchain package versions: libc0.3-dev_2.3.5-6 gcc-4.0_4.0.2-4 g++-4.0_4.0.2-4 binutils_2.16.1-2 libstdc++6-4.0-dev_4.0.2-4 libstdc++6_4.0.2-4
------------------------------------------------------------------------------
dpkg-source: extracting vim in vim-6.4
dpkg-source: unpacking vim_6.4.orig.tar.gz
dpkg-source: applying /org/buildd/build/vim_6.4-004+2.diff.gz
dpkg-buildpackage: source package is vim
dpkg-buildpackage: source version is 1:6.4-004+2
dpkg-buildpackage: host architecture hurd-i386
[...]
applying debian patch: 304_memline.c.diff
[...]
gcc -c -I. -Iproto -DHAVE_CONFIG_H     -O2 -g -Wall -DFEAT_AUTOCMD -DFEAT_BYTEOFF -DFEAT_CMDL_COMPL -DFEAT_CMDHIST -DFEAT_CMDL_INFO -DFEAT_COMMENTS -DFEAT_DIFF -DFEAT_DIGRAPHS -DFEAT_EVAL -DFEAT_SEARCH_EXTRA -DFEAT_SEARCHPATH -DFEAT_INS_EXPAND -DFEAT_LISTCMDS -DFEAT_QUICKFIX -DFEAT_SCROLLBIND -DFEAT_SMARTINDENT -DFEAT_VIMINFO -DFEAT_VERTSPLIT -DFEAT_VISUALEXTRA  -I/usr/X11R6/include       -o objects/memline.o memline.c
In file included from vim.h:154,
                 from memline.c:48:
feature.h:126:1: warning: "FEAT_CMDHIST" redefined
<command line>:1:1: warning: this is the location of the previous definition
memline.c: In function 'resolvesymlink':
memline.c:3259: error: 'PATH_MAX' undeclared (first use in this function)
memline.c:3259: error: (Each undeclared identifier is reported only once
memline.c:3259: error: for each function it appears in.)
memline.c:3292: warning: pointer targets in passing argument 1 of 'vim_strsave' differ in signedness
memline.c:3259: warning: unused variable 'tmp'
memline.c: In function 'makeswapname':
memline.c:3326: error: 'PATH_MAX' undeclared (first use in this function)
memline.c:3326: warning: unused variable 'fname'
make[2]: *** [objects/memline.o] Error 1
make[2]: Leaving directory `/build/buildd/vim-6.4/vim64/src'
make[1]: *** [first] Error 2
make[1]: Leaving directory `/build/buildd/vim-6.4/vim64'
make: *** [build-stamp-vim-tiny] Error 2
rm configure-stamp-vim-tiny
******************************************************************************
Build finished at 20051221-1305
FAILED [dpkg-buildpackage died]

The full build log can be found here:
http://experimental.ftbfs.de/fetch.php?&pkg=vim&ver=1%3A6.4-004%2B2&arch=hurd-i386&stamp=1135166920&file=log&as=raw

Patch #304 introduced an unconditional use of PATH_MAX.  As there is no
path name limit on GNU, PATH_MAX need not be defined.  The attached
patch updates #304 to #define PATH_MAX if it is not.


cheers,

Michael

--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="304_memline.c.diff"

diff -u vim64.new/src/memline.c vim64.new/src/memline.c
--- vim64.new/src/memline.c     2005-11-18 09:18:01.000000000 -0500
+++ vim64.new/src/memline.c     2005-11-25 17:41:04.000000000 -0500
@@ -58,6 +58,10 @@
 # include <proto/dos.h>	    /* for Open() and Close() */
 #endif
 
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
+
 typedef struct block0		ZERO_BL;    /* contents of the first block */
 typedef struct pointer_block	PTR_BL;	    /* contents of a pointer block */
 typedef struct data_block	DATA_BL;    /* contents of a data block */
@@ -3251,6 +3255,69 @@
     }
 }
 
+    int
+resolvesymlink(fname, buf, bufsiz)
+    char_u	*fname, *buf;
+    size_t	bufsiz;
+{
+    char_u	tmp[PATH_MAX];
+    int ret;
+
+    if (fname == NULL)
+	return 0;
+    STRCPY(tmp, fname);
+    do
+    {
+	ret = readlink((char *) tmp, (char *) buf, bufsiz);
+	if (ret == -1)
+	{
+	    if (errno == EINVAL)  /* found non-symlink */
+		STRCPY(buf, tmp);
+	    else
+		return ret;
+	}
+	else
+	{
+	    /*
+	     * check whether the symlink is relative or absolute.
+	     * If it's relative, build a new path based on the directory
+	     * portion of the filename (if any) and the path the symlink
+	     * points to.
+	     */
+	    if (!mch_isFullName(buf))
+	    {
+		char_u *p, *dir;
+		p = tmp + STRLEN(tmp) - 1;
+		while (!vim_ispathsep(*p) && (p >= tmp))
+		    --p;
+		if (p >= tmp) /* pathsep was found */
+		    p = vim_strnsave(tmp, p - tmp);
+		else
+		    p = vim_strsave(".");
+		dir = concat_fnames(p, buf, TRUE);
+		STRNCPY(tmp, dir, PATH_MAX);
+		vim_free(dir);
+		vim_free(p);
+	    }
+	    else
+		STRNCPY(tmp, buf, PATH_MAX);
+	}
+    } while (ret != -1);
+
+    /*
+     * Try to resolve the full name of the file so the swapfile name will be
+     * consistent even when opening a relative symlink from different working
+     * directories.
+     */
+    if (vim_FullName(buf, tmp, PATH_MAX, TRUE) == OK)
+    {
+	STRCPY(buf, tmp);
+	return 0;
+    }
+    else
+	return ret;
+}
+
 /*
  * make swap file name out of the file name and a directory name
  */
@@ -3260,6 +3327,8 @@
     char_u	*dir_name;
 {
     char_u	*r, *s;
+    char_u	fname[PATH_MAX];
+    char_u	*fname_p = NULL;
 
 #if defined(UNIX) || defined(WIN3264)  /* Need _very_ long file names */
     s = dir_name + STRLEN(dir_name);
@@ -3275,6 +3344,12 @@
     }
 #endif
 
+    if (buf->b_fname != NULL)
+    {
+	fname_p = fname;
+	if (resolvesymlink(buf->b_fname, fname, PATH_MAX) == -1)
+	    fname_p = buf->b_fname; /* symlink resolution failed */
+    }
     r = buf_modname(
 #ifdef SHORT_FNAME
 	    TRUE,
@@ -3285,7 +3360,7 @@
 	    /* Avoid problems if fname has special chars, eg <Wimp$Scrap> */
 	    buf->b_ffname,
 #else
-	    buf->b_fname,
+	    fname_p,
 #endif
 	    (char_u *)
 #if defined(VMS) || defined(RISCOS)

--FL5UXtIhxfXey3p5--

---------------------------------------
Received: (at 348170-close) by bugs.debian.org; 15 Jan 2006 19:41:59 +0000
>From katie at ftp-master.debian.org Sun Jan 15 11:41:59 2006
Return-path: <katie at ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
	id 1EyDc0-0007o1-Mg; Sun, 15 Jan 2006 11:32:24 -0800
From: Norbert Tretkowski <nobse at debian.org>
To: 348170-close at bugs.debian.org
X-Katie: $Revision: 1.65 $
Subject: Bug#348170: fixed in vim 1:6.4-006+2
Message-Id: <E1EyDc0-0007o1-Mg at spohr.debian.org>
Sender: Archive Administrator <katie at ftp-master.debian.org>
Date: Sun, 15 Jan 2006 11:32:24 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: vim
Source-Version: 1:6.4-006+2

We believe that the bug you reported is fixed in the latest version of
vim, which is due to be installed in the Debian FTP archive:

vim-common_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-common_6.4-006+2_i386.deb
vim-doc_6.4-006+2_all.deb
  to pool/main/v/vim/vim-doc_6.4-006+2_all.deb
vim-full_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-full_6.4-006+2_i386.deb
vim-gnome_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-gnome_6.4-006+2_i386.deb
vim-gtk_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-gtk_6.4-006+2_i386.deb
vim-gui-common_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-gui-common_6.4-006+2_i386.deb
vim-lesstif_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-lesstif_6.4-006+2_i386.deb
vim-perl_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-perl_6.4-006+2_i386.deb
vim-python_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-python_6.4-006+2_i386.deb
vim-ruby_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-ruby_6.4-006+2_i386.deb
vim-runtime_6.4-006+2_all.deb
  to pool/main/v/vim/vim-runtime_6.4-006+2_all.deb
vim-tcl_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-tcl_6.4-006+2_i386.deb
vim-tiny_6.4-006+2_i386.deb
  to pool/main/v/vim/vim-tiny_6.4-006+2_i386.deb
vim_6.4-006+2.diff.gz
  to pool/main/v/vim/vim_6.4-006+2.diff.gz
vim_6.4-006+2.dsc
  to pool/main/v/vim/vim_6.4-006+2.dsc
vim_6.4-006+2_i386.deb
  to pool/main/v/vim/vim_6.4-006+2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 348170 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Norbert Tretkowski <nobse at debian.org> (supplier of updated vim package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 15 Jan 2006 19:41:58 +0100
Source: vim
Binary: vim-full vim-lesstif vim-common vim-gnome vim-doc vim-runtime vim vim-gtk vim-perl vim-ruby vim-gui-common vim-tiny vim-python vim-tcl
Architecture: source all i386
Version: 1:6.4-006+2
Distribution: unstable
Urgency: low
Maintainer: Debian VIM Maintainers <pkg-vim-maintainers at lists.alioth.debian.org>
Changed-By: Norbert Tretkowski <nobse at debian.org>
Description: 
 vim        - Vi IMproved - enhanced vi editor
 vim-common - Vi IMproved - Common files
 vim-doc    - Vi IMproved - HTML documentation
 vim-full   - Vi IMproved - enhanced vi editor - full fledged version
 vim-gnome  - Vi IMproved - enhanced vi editor - with GNOME2 GUI
 vim-gtk    - Vi IMproved - enhanced vi editor - with GTK2 GUI
 vim-gui-common - Vi IMproved - Common GUI files
 vim-lesstif - Vi IMproved - enhanced vi editor - with LessTif GUI
 vim-perl   - Vi IMproved - enhanced vi editor - with Perl support
 vim-python - Vi IMproved - enhanced vi editor - with Python support
 vim-ruby   - Vi IMproved - enhanced vi editor - with Ruby support
 vim-runtime - Vi IMproved - Runtime files
 vim-tcl    - Vi IMproved - enhanced vi editor - with TCL support
 vim-tiny   - Vi IMproved - enhanced vi editor - compact version
Closes: 343402 344608 344658 347912 348170
Changes: 
 vim (1:6.4-006+2) unstable; urgency=low
 .
   [ Norbert Tretkowski ]
   * debian/README.Debian: fixed typos (closes: #344608)
   * patches/148_debchangelog.vim.diff: added sarge-{backports|volatile} to
     debchangelog hilighting
   * debian/control: removed build-dependencies added for woody backport
   * debian/control: build-depend on make (>= 3.80+3.81.b4)
 .
   [ Matthijs Mohlmann and Stefano Zacchiroli ]
   * debian/rules: moved "export DH_OPTIONS" back to the beginning of the
     file since old versions of make can't cope with it on
     target-specific variables. Fixes FTBFS on some archs.
     (closes: #344658)
 .
   [ Stefano Zacchiroli ]
   * debian/rules: added 'export' target to generate source package
   * debian/rules: uses quilt to manage debian-specific patches, changed
     build-deps accordingly
   * Added patch 152_javascript.vim which fixes JavaScript syntax
     highlighting (closes: #343402)
 .
   [ Pierre Habouzit ]
   * debian/control: fix vim-gui-common description. (closes: #347912)
   * 304_memline.c.diff causes FTBFS on Hurd, fix it. (closes: #348170)
Files: 
 83bfe704053603e14cd7570580a7eb04 1331 editors optional vim_6.4-006+2.dsc
 397980cb96805a2a2ed38c4f17f1dbc3 178076 editors optional vim_6.4-006+2.diff.gz
 29c2825bed93dd0cd7941e4cc86a0ad4 3591364 editors optional vim-runtime_6.4-006+2_all.deb
 04cad1cd794376bde24f72c5cf347133 1730450 editors optional vim-doc_6.4-006+2_all.deb
 5f1660fb41653f83763da095226d5040 385550 editors optional vim-tiny_6.4-006+2_i386.deb
 087930e054bc0981d28168c4d2ffbd20 744160 editors extra vim-ruby_6.4-006+2_i386.deb
 9dd91fc6ed6b81e6ff8e116433f3df95 709562 editors extra vim-tcl_6.4-006+2_i386.deb
 3e0c6c27b4f00a0f555b929814ac65c7 701616 editors extra vim-gtk_6.4-006+2_i386.deb
 3ed5e7a981d3caa1d85ff308775c4704 682736 editors extra vim-lesstif_6.4-006+2_i386.deb
 4123964c3b83cd6210d6e0a74c784455 755998 editors extra vim-perl_6.4-006+2_i386.deb
 68208089ebfe77548580b0cc9ef273cc 749018 editors extra vim-python_6.4-006+2_i386.deb
 f796f7e8bced26e590e9cb5b36efaf52 703616 editors extra vim-gnome_6.4-006+2_i386.deb
 6e3a16164b96a48a95036c5f6354a6a3 778484 editors extra vim-full_6.4-006+2_i386.deb
 1189e2357cc835046c18189b78c997c1 81058 editors optional vim-common_6.4-006+2_i386.deb
 51b9318acc00d8436eb4934dd5d3b0f2 67604 editors optional vim-gui-common_6.4-006+2_i386.deb
 411448cd445deb42d3df950249b33ed0 585870 editors optional vim_6.4-006+2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDyqDgr/RnCw96jQERAqqrAJ9aBpFUpNDNVduKazkxjpWRFg89ZgCgpL5k
eT00pDkXZPaW8g4rggXI+FQ=
=aaPW
-----END PGP SIGNATURE-----




More information about the pkg-vim-maintainers mailing list