[Pkg-virtualbox-devel] Some comments about the build process

[Hilko Bengen]

Michael Meskes <meskes at debian.org> writes:

> But still, where is the advantage?

I'll admit that I can't really come up with a problem that couldn't be
worked around with the existing configure script. But there is one
change I'd like to make that would make the `install' target much
simpler:

 	dh_testdir
 
 	# Building package
-	$(MAKE) BUILD_TYPE=release
+	$(MAKE) \
+		BUILD_TYPE=release \
+		PATH_OUT=$(abspath out)
 	# make sure VBoxAddIF.sh is built, too
-	$(MAKE) -C src/VBox/Installer/linux `echo $(CURDIR)/out/linux.*/release/bin`/VBoxAddIF.sh
+	$(MAKE) -C src/VBox/Installer/linux $(abspath out/bin/VBoxAddIF.sh) \
+		PATH_OUT=$(abspath out)
 
 	touch build-stamp
 
[...]

 	# Installing virtualbox
-	cp -r out/linux.*/release/bin debian/$(sname)/usr/lib/virtualbox
+	cp -r out/bin debian/$(sname)/usr/lib/virtualbox
 	# move architecture independant files to /usr/share/virtualbox instead of /usr/lib/virtualbox
 	mv debian/$(sname)/usr/lib/virtualbox/nls debian/$(sname)/usr/share/virtualbox
 	mv debian/$(sname)/usr/lib/virtualbox/sdk debian/$(sname)/usr/share/virtualbox
 	mv debian/$(sname)/usr/share/virtualbox/sdk/bin/xpidl debian/$(sname)/usr/lib/virtualbox/
[...]

PATH_OUT is normally set to out/${architecture_string}/release.
For building, we don't really need that architecture-specific part, AFAICS.

I have just built packages and verified that all the files still get
installed.

BTW, there are some of files starting with `tst' and a `testcase'
subdirectory below /usr/lib/virtualbox-ose. Do we really want to ship those?

Cheers,
-Hilko