[Pkg-virtualbox-devel] Bug#451742: Bug#451742: Don't modprobe vboxadd

[Kel Modderman]

On Monday 19 November 2007 20:04:05 Michael Meskes wrote:
> Hi Kel,
>
> > I have attached patch below to improve upon what is committed to
> > pkg-virtualbox in r116 and r118.
>
> Thanks. Committed.

Cool, thanks alot. In try2 patch i sent before i simply changed:

log_action_begin_msg 'VirtualBox Additions Disabled';
log_warning_msg 'not in a Virtual Machine environemnt';
log_end_msg 0

to:

log_warning_msg 'VirtualBox Additions Disabled, not in a Virtual Machine';

in in_virtual_machine()

>
> > The committed lspci check will not work, because vendor id and device id
> > is not provided in the default lspci output stream. A better way would be
> > to do a
>
> Sorry, but for me it does:
>
> michael at virtualsid:~$ lspci
> 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev
> 02) 00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton
> II] 00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE
> [Natoma/Triton II] 00:02.0 VGA compatible controller: Unknown device
> 80ee:beef
> 00:03.0 Ethernet controller: Advanced Micro Devices [AMD] 79c970 [PCnet32
> LANCE] (rev 40) 00:04.0 System peripheral: Unknown device 80ee:cafe
> 00:07.0 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 08)
>
> If the device was known the ids wouldn't be displayed though.

Ah, yep. My shiny new pciids list had it as a known device with description, 
pciutils lists are getting a bit old by now...

>
> > direct lookup using known vendor_id:device_id with the '-d' option. If a
> > string is returned then the device is present. If nothing is returned,
> > print a message stating system is not in a Virtual Machine.
>
> Good idea anyway because it removes one pipe.

Thanks again, Kel.