[Pkg-virtualbox-devel] Bug#474089: Bug#474089: closed by Michael Meskes

[Michael Biebl]

Michael Meskes wrote:
> On Sun, Aug 24, 2008 at 09:29:03PM +0200, Michael Biebl wrote:
>> NOLSB=yes
>> [..]
>> [ -f /lib/lsb/init-functions ] || NOLSB=yes
>>
>> ==> NOLSB will never be no
> 
> This is not exactly true because in [...] /etc/default/virtualbox-ose is
> sourced if available. Thus NOLSB could be reset there.

Could be, but afaics it isn't atm. And I really think that this is a
config variable that should not be manipulated by the user.

Either you have the lsb logging functions, then use it, otherwise not.

>> Don't make a lot of sense, as the NOLSB variable will never be empty
> 
> Again, it could be set in the default file. However, I do agree that the test should be the other way round:
> 
> [ -f /lib/lsb/init-functions ] && NOLSB=

I guess this would work. Please keep in mind to never use "set -e" then,
otherwise your script will exit at this point if /lib/lsb/init-functions
doesn't exist.

Cheers,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-virtualbox-devel/attachments/20080825/85966df3/attachment.pgp