[Pkg-virtualbox-devel] Bug#475297: Bug#475297: virtualbox-ose: New patch (for

[Michael Meskes]

On Tue, Jun 17, 2008 at 01:29:01AM +0200, Daniel Hahler wrote:
> I agree that there should probably be a "end_msg".
> 
> I've modified the patch accordingly.

To be honest I'm still not convinced.

> The reason for this patch after all is, that usplash displays the message corrupted when only using log_warning_msg, like it's done in Debian.

Unfortunately I don't have a bootsplash system to test with. Might be
worth setting one up though.

> -		log_warning_msg 'VirtualBox Additions Disabled, not in a Virtual Machine';
> +		log_action_cont_msg 'VirtualBox Additions Disabled, not in a Virtual Machine';
> +		log_end_msg 1

log_warning_message prints either "${YELLOW}*${NORMAL} $@" or just "$@"
depending on the status of log_use_fancy_output. Since I don't expect
"$@" to be a problem it's probably the fancy stuff that interacts with
the splash output.

log_action_cont_msg only outputs "$@...".

log_end_msg finally does " ${RED}failed!${NORMAL}" or " failed!"
depending again on log_use_fancy_output. That is if the argument is 1 of
course.

So log_end_msg seems to use the same fancy stuff, where is the
advantage? And the text changes some:

The original result is:
* VirtualBox Additions Disabled, not in a Virtual Machine

The new one would be:
VirtualBox Additions Disabled, not in a Virtual Machine... failed!

Quite a difference IMO.

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes at jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!