[Pkg-virtualbox-devel] Bug#526395: Bug#526395: Save ~10s in virtualbox-ose init script

[Michael Meskes]

On Thu, Apr 30, 2009 at 11:31:03PM +0200, Daniel Hahler wrote:
> Please forgive me that I have not actually tested this, but committed it for Ubuntu Karmic already.

You might want to change this some or I misunderstood.

> -+	        if ! modprobe vboxdrv > /dev/null 2>&1; then
> -+        	    failure "modprobe vboxdrv failed. Please use 'dmesg' to find out why"
> ++		if ! modprobe -n -q vboxdrv; then
> ++        	    failure "modprobe vboxdrv failed. Please use 'dmesg' to find out why."

This change makes sure the script does *not* insert the module at all. I think
the original submitter was talking about using modprobe -n instead of find and
not instead of the existing modprobe call.

I like the idea of saving some time, but I think the find command gives some
valuable information if modprobe fails.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes at jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!