[Pkg-virtualbox-devel] Bug#526395: Bug#526395: Save ~10s in virtualbox-ose init script

[Michael Meskes]

On Tue, May 05, 2009 at 01:04:51AM +0200, Daniel Hahler wrote:
> > > ++	# Why is sleep used here (in case of error)?
> > >           sleep .2
> > Should have answered this one too. I think the reason for this is to give
> > your system some time to generate the device file after inserting the
> > module.
> 
> Is this really needed? After all, the boot process goes on after that, and I 
> think loading the module should provide the device file right away?!

I'm sure upstream had a reason for this. Keep in mind that the very next
command checks for the existance of the device. That's where my guess came
from. 

> It's just 0.2s after all, but I'd like to have a reference in the comment 
> there why/when it's required.

How about asking upstream? We're patching the init script in quite some places
but for the most part it's still the one provided by upstream.

I thought about writing my own, but by using the patch system it's easier to
follow changes made by upstream for new features etc.

Michael

-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes at jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!