[Pkg-virtualbox-devel] Bug#699141: get-orig-source

[Gianfranco Costamagna]

Hi Dmitry,





> Il Domenica 20 Luglio 2014 11:28, Dmitry Smirnov <onlyjob at debian.org> ha scritto:
> > On Wed, 2 Jul 2014 11:48:12 Gianfranco Costamagna wrote:
>>  so now you can run
>>  ./debian/rules get-orig-source or directly uscan, with exactly the same
>>  behaviour.
>> 
>>  I think this is the best way, compliant with policy and not breaking the
>>  existing update procedure.
>> 
>>  I hope you agree, I committed it here
>> 
>> 
> http://anonscm.debian.org/gitweb/?p=pkg-virtualbox/virtualbox.git;a=commitdi
>>  ff;h=cb88c2a13a0fe8336831b3d63082fda348c02c4b
> 
> I'm sorry to be a pest but this solution is incomplete. When `uscan` can be 
> called with usual parameters you may need no "get-orig-source" target 
> in first 
> place. I sometimes introduce it in order to help remembering `uscan` arguments 
> which I had troubles to recall for a while.
> If you decide to use "get-orig-source" then please make sure it is 
> policy 
> compliant: it should work when called from any directory, not just from 
> current one (e.g. `/path/to/package/debian/rules get-orig-source`); it should 
> fetch ceurrent version by default etc. You can find the simplest sample of 
> properly working "get-orig-source" here:
> 
>     https://wiki.debian.org/onlyjob/get-orig-source
> 
> Note $(PKD) variable and how it is passed to `uscan`.
>

So I think this all needs to be removed then. I put in README.source the only uscan command for upgrading to a new release.
I removed the overread in d/rules.

We should be fine now, otherwise please point me to a patch since I'm a bit lost ;)

having the only "uscan" should be fine now, I don't want to create a script again, I prefer to focus to some other bugs ;)

thanks!


 
> Thank you.

thanks to you!

Cheers,

Gianfranco
> 
> -- 
> Best wishes,
> 
> Dmitry Smirnov.
>