[Pkg-virtualbox-devel] Bug#800904: virtualbox-guest-x11: notify-send in guest additions X11 client is noisy and scary

[Ronny Standtke]

Package: virtualbox-guest-x11
Version: 5.0.6-dfsg-1~bpo8+1
Severity: minor
Tags: patch

I am  maintaining a distribution based on Debian Live. We have
virtualbox-guest-x11 in our default package list so that the
distribution also runs fine in VirtualBox. But when the system is *not*
running in VirtualBox, which is the main use case, the guest additions
X11 client shows a big warning message at startup via notify-send on the
desktop. This is unnecessary and really scares normal users. Therefore I
propose to use a simple echo instead of notify-send. Please see the
attached patch for a fix.

-- System Information:
Debian Release: 8.2
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 4.2.0-1+lernstick.1-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages virtualbox-guest-x11 depends on:
ii  libc6                                  2.19-18+deb8u1
ii  libnotify-bin                          0.7.6-2
ii  libx11-6                               2:1.6.2-3
ii  libxcomposite1                         1:0.4.4-1
ii  libxdamage1                            1:1.1.4-2+b1
ii  libxext6                               2:1.3.3-1
ii  libxfixes3                             1:5.0.1-2+b2
ii  libxmu6                                2:1.1.2-1
ii  libxt6                                 1:1.1.4-1+b1
ii  virtualbox-guest-utils                 5.0.6-dfsg-1~bpo8+1
ii  xserver-xorg-core [xorg-video-abi-18]  2:1.16.4-1

virtualbox-guest-x11 recommends no packages.

virtualbox-guest-x11 suggests no packages.

-- no debconf information

-------------- next part --------------
Description: silence the guest additions X11 client
 When not running in VirtualBox, the guest additions X11 client shows a warning
 message via notify-send. This is unnecessary and scares users. Therefore
 we use a simple echo instead of notify-send.
Author: Ronny Standtke <ronny.standtke at gmx.net>

---

--- virtualbox-5.0.6-dfsg.orig/src/VBox/Additions/x11/Installer/98vboxadd-xclient
+++ virtualbox-5.0.6-dfsg/src/VBox/Additions/x11/Installer/98vboxadd-xclient
@@ -23,7 +23,7 @@ done
 
 if ! test -c /dev/vboxguest 2>/dev/null; then
    # Do not start if the kernel module is not present.
-   notify-send "VBoxClient: the VirtualBox kernel service is not running.  Exiting."
+   echo "VBoxClient: the VirtualBox kernel service is not running.  Exiting."
 elif test -z "${SSH_CONNECTION}"; then
    # This script can also be triggered by a connection over SSH, which is not
    # what we had in mind, so we do not start VBoxClient in that case.  We do