[Pkg-virtualbox-devel] Bug#748691: virtualbox autostart init script unsuitable for Debian

[Gianfranco Costamagna]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



Control: tags -1 -patch

Hi, thanks for the patch, however I can't apply it as-is.

I tried, but the init script lacks of too much stuff to be included
(and the patch should work against the debian git, not the filesystem)
this is what I did
dh_installinit -p$(sname) --no-start --name
debian/vboxautostart-service.init

in override_dh_installinit, however lintian complains a lot about the
quality of the init script.
http://debomatic-amd64.debian.net/distribution#unstable/virtualbox/5.0.1
2-dfsg-3/lintian

E: virtualbox: init.d-script-missing-dependency-on-remote_fs
etc/init.d/vboxautostart-service.init: required-start
N:
N:    The given init script seems to refer to /usr, possibly using a
file or
N:    binary from there. Without a dependency on $remote_fs in
Required-Start
N:    or Required-Stop, as appropriate, the init script might be run
before
N:    /usr is mounted or after it's unmounted.
N:
N:    Using Should-Start or Should-Stop to declare the dependency is
N:    conceptually incorrect since the $remote_fs facility is always
N:    available. Required-Start or Required-Stop should be used
instead. Also,
N:    please note that $all should not be used in Required-Stop, only
N:    Required-Start.
N:
N:    Refer to https://wiki.debian.org/LSBInitScripts for details.
N:
N:    Severity: important, Certainty: possible
N:
N:    Check: init.d, Type: binary
N:
E: virtualbox: init.d-script-missing-dependency-on-remote_fs
etc/init.d/vboxautostart-service.init: required-stop
E: virtualbox: init.d-script-does-not-implement-required-option
etc/init.d/vboxautostart-service.init restart
N:
N:    The /etc/init.d scripts have to support the following command line
N:    arguments: start, stop, restart, force-reload.
N:
N:    Refer to Debian Policy Manual section 9.3.2 (Writing the
scripts) for
N:    details.
N:
N:    Severity: important, Certainty: certain
N:
N:    Check: init.d, Type: binary
N:
E: virtualbox: init.d-script-does-not-implement-required-option
etc/init.d/vboxautostart-service.init force-reload


so for now this is a no-go, and I don't think I'll have much time in
the next days/months to fix the init script (I'm not an huge fan of
them and I lack of the competences to make them look and behave sanely)

cheers,

G.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWjRpWAAoJEPNPCXROn13ZAr8P/il2yXFJ0yJpNhlZicmQHjfh
FspjTBPCe9PfXno0PPI+jXyk5nvKiUzJnldOvuGE/onfs1F8DaCj/SwPl8pura7f
S5AmmpEjnRAHAbVhL9mqdfTPoXkloEdJTEd6BBcyNeYveesAKlwwGSRIbHDtmZwT
QsswPReKo75PYHmx3VXNZXJlFR3tqIZ6pdh0DEWEIJU5IcGcB9rvFTA/EbsYnSrG
xfvS6a+LZVgshDPioRIxRYDM0acXYN3S1DYVslKdRHYQj+KF0hl3Aecrzc3062pj
clyBh8vhGBuFff9bhs9ZhK5MBjtSSwDABHZjxpXt+8k87S7GPDmWKcaLbZACH56i
n62E4LvBH77PHwu51EzMrnacrzDEzGTXCuTIyQvrYU1vILssha3lziR+Y7v//VIu
0s3j90uC3DmDsF/tcad/JdM7OnseKkxVxnTl5BEq0Skd8GsWOM2A9MEKSn8Dgfjn
l/OCRkN3koWwIIGb/+Y//Jp05y8DdlQHR89NqNmB3RjpAR+VUczq9ss0WWpkNkRJ
S1eItcutK/aY1s8DbMMLlfd4mt7rYT4d6he4UNzOfjJSKkuwZQ0YhTkeSQ/BcxAD
/qQ0r40MAY4MqP4CO0QXm9tJjSoyN1tcCOXabaLirYGYQotvvHTlfgNNvkw9qQEK
5G4cbn9bcqtZblmGBZ7w
=cs6p
-----END PGP SIGNATURE-----