[Pkg-virtualbox-devel] Bug#890069: syntax error in /etc/init.d/virtualbox hard kills VMs on host shutdown

[Manfred Frank]

Package: virtualbox

Version: 5.1.14-dfsg-1

Severity: important

On host shutdown, usually virtualbox does follow /etc/init.d/virtualbox. 
this file has an syntax error that leads to VMs being hard killed as the 
stop function is not working at all while the host goes down.

I my  self am no script boy, so I have no clue whats exactly the reason 
for this, I only know, the shutdown script did not work as intended. And 
I was not the only one with the problem. I was looking the very first 
time into the Linux shutdown routine. And by some luck I got a clue from 
the code highlighting function in VIM while looking at 
/etc/init.d/virtualbox: Something is amiss with the stop() function.

I modified the code "stop()" to "hstop()" (h for no reason, but I did 
later try c for custom but that does not work either) and changed all 
calls to "stop" from "stop" to "hstop". With this modification the 
shutdown code is working now as intended. see picture for where I got my 
hint from.

Again, I am no coder and I have no clue as to why thats a syntax error, 
for me it does look perfectly right in the original version, but it wont 
work that way.

My OS is openmediavault 3.0.96 (Erasmus)
4.9.0-0.bpo.5-amd64 #1 SMP Debian 4.9.65-3+deb9u2~bpo8+1

On the machine I did discover this bug, virtualbox is part of the 
omv-extra.org plugin collection. I did notify the plugin 
maintainer/admin of omv-extra.org via forum.openmedavault.org, he 
suggested to report it.

More details see: 
https://forum.openmediavault.org/index.php/Thread/21643-Virtualbox-does-NOT-shutdown-VMs-gracefully-when-OMV-host-goes-down-eg-power-fai/?postID=167615#post167615

Hope this is a hint for you guys to track it down.

regards

ManneBK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.png
Type: image/png
Size: 101743 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-virtualbox-devel/attachments/20180210/c0301ca6/attachment-0001.png>