[Pkg-virtualbox-devel] Bug#880594: virtualbox-guest-x11: 98vboxadd-xclient calls notify-send before Plasma is started, causing SDDM to hang

[Gianfranco Costamagna]

control: tags -1 moreinfo

Hello Rohan,
On Thu, 02 Nov 2017 17:13:51 +0100 Rohan Garg <rohan at kde.org> wrote:
> Package: virtualbox-guest-x11
> Severity: normal
> 
> Dear Maintainer,
> Due to a recent change in Plasma, a call to notify-send is blocked till such time
> Plasma has started. 98vboxadd-xclient calls notify-send before Plasma is started,
> blocking SDDM and delaying the start of Plasma.
> 
> See https://phabricator.kde.org/D5012 for a discussion about the change.
> 
> Perhaps a good idea would be to either fork that call.
> 

what is the approach you are suggesting?
this?
git diff
diff --git a/src/VBox/Additions/x11/Installer/98vboxadd-xclient b/src/VBox/Additions/x11/Installer/98vboxadd-xclient
index 985e9e7ab..8187a3fe4 100755
--- a/src/VBox/Additions/x11/Installer/98vboxadd-xclient
+++ b/src/VBox/Additions/x11/Installer/98vboxadd-xclient
@@ -23,7 +23,7 @@ done
 
 if ! test -c /dev/vboxguest 2>/dev/null; then
    # Do not start if the kernel module is not present.
-   notify-send "VBoxClient: the VirtualBox kernel service is not running.  Exiting."
+   notify-send "VBoxClient: the VirtualBox kernel service is not running.  Exiting." &
 elif test -z "${SSH_CONNECTION}"; then
    # This script can also be triggered by a connection over SSH, which is not
    # what we had in mind, so we do not start VBoxClient in that case.  We do


I fail to see notify-send calls in the code that might give such troubles, specically because they are ran in
error conditions that will unlikely be part of Debian use-cases (e.g. /dev/vboxguest exists always in Debian context


BTW can you please report this upstream? this seems not a Debian specific issue


G.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-virtualbox-devel/attachments/20180315/8c7dfbbe/attachment.sig>