[Pkg-voip-commits] r2337 - asterisk/trunk/debian

[Tzafrir Cohen]

On Sat, Sep 02, 2006 at 07:00:20PM +0000, Mark Purcell wrote:
> Author: msp
> Date: 2006-09-02 19:00:19 +0000 (Sat, 02 Sep 2006)
> New Revision: 2337
> 
> Modified:
>    asterisk/trunk/debian/asterisk.init
> Log:
> Releasing
> 
> Modified: asterisk/trunk/debian/asterisk.init
> ===================================================================
> --- asterisk/trunk/debian/asterisk.init	2006-09-02 12:01:24 UTC (rev 2336)
> +++ asterisk/trunk/debian/asterisk.init	2006-09-02 19:00:19 UTC (rev 2337)
> @@ -93,7 +93,7 @@
>    start)
>  	if status > /dev/null; then
>  		echo "$DESC is already running. Use restart."
> -		exit 1
> +		exit 0
>  	fi
>  	echo -n "Starting $DESC: "
>  	if [ "$RUNASTSAFE" != "yes" ];then
> @@ -102,7 +102,7 @@
>  		# "safe mode"
>  		if status > /dev/null; then
>  			echo "$DESC is already running. Use restart."
> -			exit 1
> +			exit 0
>  		fi
>  		start-stop-daemon --start --group $GROUP --pidfile "$PIDFILE" \
>  			--exec $REALDAEMON -- $PARAMS

The operation has failed. Shouldn't it return an error?

Can't this cause some scripts to silently "succeed"?

-- 
Tzafrir Cohen         sip:tzafrir at local.xorcom.com
icq#16849755          iax:tzafrir at local.xorcom.com
+972-50-7952406          jabber:tzafrir at jabber.org
tzafrir.cohen at xorcom.com     http://www.xorcom.com