[Pkg-voip-commits] r6187 - in /asterisk/trunk/debian: asterisk.default asterisk.init changelog

[lmamane at alioth.debian.org]

Author: lmamane
Date: Wed Sep 10 01:35:03 2008
New Revision: 6187

URL: http://svn.debian.org/wsvn/pkg-voip/?sc=1&rev=6187
Log:
/etc/default/asterisk:

 - Bring comments on AST_DUMPCORE in sync with reality of
   implementation in /etc/init.d/asterisk.

 - Change suggested CORE_PATTERN to more secure ones.

Modified:
    asterisk/trunk/debian/asterisk.default
    asterisk/trunk/debian/asterisk.init
    asterisk/trunk/debian/changelog

Modified: asterisk/trunk/debian/asterisk.default
URL: http://svn.debian.org/wsvn/pkg-voip/asterisk/trunk/debian/asterisk.default?rev=6187&op=diff
==============================================================================
--- asterisk/trunk/debian/asterisk.default (original)
+++ asterisk/trunk/debian/asterisk.default Wed Sep 10 01:35:03 2008
@@ -50,11 +50,16 @@
 #               CORE_PATTERN below.
 #AST_DUMPCORE=yes
 #
-# DUMPCORE_DIR: By default asterisk runs in the directory '/' like any 
+# AST_DUMPCORE_DIR: By default asterisk runs in the directory '/' like any 
 #               daemon. Setting this allows you to tell it to tell the 
 #               Asterisk daemon to run in a different directory if 
-#               AST_DUMPCORE is enabled. The default is /tmp and is 
-#               probably a sane one.
+#               AST_DUMPCORE is enabled. The default is
+#               /var/spool/asterisk. That is a good choice because it
+#               is writable (thus enabling the actual writing of the
+#               core file) but relatively immune to symlink attacks
+#               (because not world-writable like /tmp/).
+#               Note, however, that if CORE_PATTERN is an absolute
+#               path, it will override AST_DUMPCORE_DIR.
 #
 # CORE_PATTERN: If you use AST_DUMPCORE above, this is optionally set to a 
 #               pattern of the core file. The default is not to touch the 
@@ -68,6 +73,6 @@
 #               See http://lxr.linux.no/source/Documentation/sysctl/kernel.txt
 #               Here is what Asterisk's ast_grab_core
 #               script would expect:
-#CORE_PATTERN='/tmp/core.%p'
+#CORE_PATTERN='core.%p'
 #               But you might prefer something like:
-#CORE_PATTERN='/tmp/core.%e.%t'
+#CORE_PATTERN='core.%e.%t'

Modified: asterisk/trunk/debian/asterisk.init
URL: http://svn.debian.org/wsvn/pkg-voip/asterisk/trunk/debian/asterisk.init?rev=6187&op=diff
==============================================================================
--- asterisk/trunk/debian/asterisk.init (original)
+++ asterisk/trunk/debian/asterisk.init Wed Sep 10 01:35:03 2008
@@ -52,8 +52,7 @@
 AST_REALTIME="yes"
 RUNASTERISK="yes"
 AST_DUMPCORE="no"
-AST_DUMPCORE_DIR="/tmp" # only used if AST_DUMPCORE != yes
-AST_DUMPCORE_DIR="/var/spool/asterisk"
+AST_DUMPCORE_DIR="/var/spool/asterisk" # only used if AST_DUMPCORE != no
 # core_pattern. See: http://lxr.linux.no/source/Documentation/sysctl/kernel.txt
 #CORE_PATTERN=
 if [ -r /etc/default/$NAME ]; then . /etc/default/$NAME; fi

Modified: asterisk/trunk/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-voip/asterisk/trunk/debian/changelog?rev=6187&op=diff
==============================================================================
--- asterisk/trunk/debian/changelog (original)
+++ asterisk/trunk/debian/changelog Wed Sep 10 01:35:03 2008
@@ -18,7 +18,12 @@
   [ Tzafrir Cohen ]
   * Patch fix_zap_no_timing_source: hopefully fixes 491310
 
- -- Tzafrir Cohen <tzafrir.cohen at xorcom.com>  Mon, 18 Aug 2008 13:56:26 +0300
+  [ Lionel Elie Mamane ]
+  * /etc/default/asterisk: Bring comments on AST_DUMPCORE in sync with
+    reality of implementation in /etc/init.d/asterisk. Change suggested
+    CORE_PATTERN to more secure ones.
+
+ -- Lionel Elie Mamane <lmamane at debian.org>  Wed, 10 Sep 2008 03:19:34 +0200
 
 asterisk (1:1.4.21.2~dfsg-1) unstable; urgency=high